Skip to content

fix: convert clip data into plain text before pasting to omnibar #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2021
Merged

fix: convert clip data into plain text before pasting to omnibar #1105

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bdde24
fix: convert clip data into plain text before pasting to omnibar.
Feb 16, 2021
e97b3cc
fix: apply style guide
Feb 17, 2021
2f86423
refactoring: encapsulate obtaining ClipboardManager from context
Feb 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions app/src/main/java/com/duckduckgo/app/browser/omnibar/KeyboardAwareEditText.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@

package com.duckduckgo.app.browser.omnibar

import android.content.ClipData
import android.content.ClipboardManager
import android.content.Context
import android.graphics.Rect
import android.os.Build
import android.text.Editable
import android.util.AttributeSet
import android.util.Patterns
Expand Down Expand Up @@ -74,6 +77,31 @@ class KeyboardAwareEditText : AppCompatEditText {
}
}

/**
* Overrides to paste clip data without rich text formatting.
*/
override fun onTextContextMenuItem(id: Int): Boolean = when (id) {
android.R.id.paste ->
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
super.onTextContextMenuItem(android.R.id.pasteAsPlainText)
} else {
context.getClipboardManager().convertClipToPlainText()
super.onTextContextMenuItem(id)
}
else -> super.onTextContextMenuItem(id)
}

private fun Context.getClipboardManager(): ClipboardManager =
getSystemService(Context.CLIPBOARD_SERVICE) as ClipboardManager

private fun ClipboardManager.convertClipToPlainText() {
val clip = primaryClip ?: return
for (i in 0 until clip.itemCount) {
val text = clip.getItemAt(i).coerceToText(context)
setPrimaryClip(ClipData.newPlainText(null, text))
}
}

interface OnBackKeyListener {

fun onBackKey(): Boolean
Expand Down