Skip to content

Conversation

@marcosholgado
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414730916066338/1200270570497000
Tech Design URL:
CC:

Description:
This PR clears the navigation stack when a user has gone back to the home screen and makes a new search or goes to a new URL.

Steps to test this PR:

  1. Open a new tab
  2. Go to as.com (site A)
  3. Press back → going back to home tab
  4. Go to marca.com (site B)
  5. Site A doesn't load
  6. Press back
  7. You should now be on the home screen

Internal references:

Software Engineering Expectations
Technical Design Template

@cmonfortep cmonfortep self-assigned this Jun 16, 2021
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 1 line change to fix them all.

image

@marcosholgado marcosholgado merged commit 5573125 into develop Jun 17, 2021
@marcosholgado marcosholgado deleted the features/marcos/reset_nav_stack_correctly branch June 17, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants