Fix: nav history not cleared when favorite clicked #1285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1200484661445644/f
Tech Design URL:
CC:
Description:
Follow up of #1284
We fixed clearing the navigation when the user submits a new query from the home tab, however, when the user clicks on a favorite the issue was still present.
We detected that
ResetHistorywas emitted from the viewmodel but not received in the fragment, and we don't know why that happens.Bug behavior:
-> quickAccessAdapter item clicked ->
viewModel.onQuickAccesItemClicked->Command.SubmitQuery->viewModel.onUserSubmittedQuery->Command.ResetHistoryandCommand.Navigate-> ❌ResetHistorycommand not received, ✅Navigatecommand receivedFix:
-> quickAccessAdapter item clicked ->
viewModel.onUserSubmittedQuery->Command.ResetHistoryandCommand.Navigate-> ✅ResetHistorycommand not received, ✅Navigatecommand receivedSteps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template