Skip to content

Conversation

@cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented Jun 17, 2021

Task/Issue URL: https://app.asana.com/0/414730916066338/1200484661445644/f
Tech Design URL:
CC:

Description:

Follow up of #1284

We fixed clearing the navigation when the user submits a new query from the home tab, however, when the user clicks on a favorite the issue was still present.

We detected that ResetHistory was emitted from the viewmodel but not received in the fragment, and we don't know why that happens.

Bug behavior:
-> quickAccessAdapter item clicked -> viewModel.onQuickAccesItemClicked -> Command.SubmitQuery -> viewModel.onUserSubmittedQuery-> Command.ResetHistory and Command.Navigate -> ❌ ResetHistory command not received, ✅Navigate command received

Fix:
-> quickAccessAdapter item clicked -> viewModel.onUserSubmittedQuery -> Command.ResetHistory and Command.Navigate -> ✅ ResetHistory command not received, ✅Navigate command received

Steps to test this PR:

  1. Run the app with at least 1 favorite
  2. Open a new tab
  3. Go to as.com (site A)
  4. Press back → going back to home tab
  5. Click on a favorite
  6. Site A doesn't load
  7. Press back
  8. You should now be on the home screen

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! Nice one. I left just one comment to remove SubmitQuery from the Commands, apart from that all good!

@cmonfortep cmonfortep merged commit 0dcbc5c into develop Jun 21, 2021
@cmonfortep cmonfortep deleted the bug/cristian/reset_history_quickaccessgrid branch June 21, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants