[BUG] Fix crash when accidentally returning binding.root in onCreateView #1350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitorvs
force-pushed
the
fix/aitor/require_view_crash
branch
from
db4c471 to
7f31bb7
Compare
cmonfortep
approved these changes
Aug 4, 2021
Contributor
cmonfortep
left a comment
cmonfortep
left a comment
There was a problem hiding this comment.
LGTM 👍 All good! Thanks for fixing it so quick.
| override fun onActivityCreated(savedInstanceState: Bundle?) { | ||
| super.onActivityCreated(savedInstanceState) | ||
|
|
||
| recyclerAdapter = MainReasonAdapter(object : (FeedbackTypeMainReasonDisplay) -> Unit { |
Contributor
There was a problem hiding this comment.
We could even create the adapter using by lazy directly in the var declaration if we like more that style. In any case 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1200701185339109/f
Tech Design URL:
CC:
Description:
This PR fixes a crash that happened when submitting negative feedback.
In
MainReasonNegativeFeedbackFragmentandSubReasonNegativeFeedbackFragmentwe were doing some logic inonCreateViewand then returningbinding.root. But Android does not allow to use view binding insideonCreateViewthat should return an inflated view, which at that point it is not.This PR moves the logic performed in the
onCreateViewmethod to theonActivityCreatedmethod--which is the next lifecycle method to be called--so that we can continue using view bindingSteps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template