Skip to content

[BUG] Fix crash when accidentally returning binding.root in onCreateView #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2021
Merged

[BUG] Fix crash when accidentally returning binding.root in onCreateView #1350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions .../com/duckduckgo/app/feedback/ui/negative/mainreason/MainReasonNegativeFeedbackFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
package com.duckduckgo.app.feedback.ui.negative.mainreason

import android.os.Bundle
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.core.content.ContextCompat
import androidx.recyclerview.widget.LinearLayoutManager
import com.duckduckgo.app.browser.R
Expand All @@ -44,19 +41,15 @@ class MainReasonNegativeFeedbackFragment : FeedbackFragment(R.layout.content_fee
private val listener: MainReasonNegativeFeedbackListener?
get() = activity as MainReasonNegativeFeedbackListener

override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
override fun onActivityCreated(savedInstanceState: Bundle?) {
super.onActivityCreated(savedInstanceState)

recyclerAdapter = MainReasonAdapter(object : (FeedbackTypeMainReasonDisplay) -> Unit {
Copy link
Contributor

@cmonfortep cmonfortep Aug 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could even create the adapter using by lazy directly in the var declaration if we like more that style. In any case 👍

override fun invoke(reason: FeedbackTypeMainReasonDisplay) {
listener?.userSelectedNegativeFeedbackMainReason(reason.mainReason)
}
})

return binding.root
}

override fun onActivityCreated(savedInstanceState: Bundle?) {
super.onActivityCreated(savedInstanceState)

activity?.let {
binding.recyclerView.layoutManager = LinearLayoutManager(it)
binding.recyclerView.adapter = recyclerAdapter
Expand Down
13 changes: 3 additions & 10 deletions ...va/com/duckduckgo/app/feedback/ui/negative/subreason/SubReasonNegativeFeedbackFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
package com.duckduckgo.app.feedback.ui.negative.subreason

import android.os.Bundle
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.core.content.ContextCompat
import androidx.recyclerview.widget.LinearLayoutManager
import com.duckduckgo.app.browser.R
Expand Down Expand Up @@ -52,7 +49,9 @@ class SubReasonNegativeFeedbackFragment : FeedbackFragment(R.layout.content_feed

private lateinit var mainReason: MainReason

override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
override fun onActivityCreated(savedInstanceState: Bundle?) {
super.onActivityCreated(savedInstanceState)

recyclerAdapter = SubReasonAdapter(object : (FeedbackTypeSubReasonDisplay) -> Unit {
override fun invoke(reason: FeedbackTypeSubReasonDisplay) {
when (reason.subReason) {
Expand All @@ -72,12 +71,6 @@ class SubReasonNegativeFeedbackFragment : FeedbackFragment(R.layout.content_feed
}
})

return binding.root
}

override fun onActivityCreated(savedInstanceState: Bundle?) {
super.onActivityCreated(savedInstanceState)

activity?.let {
binding.recyclerView.layoutManager = LinearLayoutManager(it)
binding.recyclerView.adapter = recyclerAdapter
Expand Down