Skip to content

Conversation

@subsymbolic
Copy link
Contributor

@subsymbolic subsymbolic commented Oct 9, 2018

Task/Issue URL: https://app.asana.com/0/361428290920652/850930018552054

Description:
Fixes issue where bad bloom data could cause the app to crash. Also performed some tidy up.

Steps to test this PR:

  1. Run the app on an emulator
  2. Once a sync has finished delete the file at /data/data/com.duckduckgo.mobile.android/files/HTTPS_BINARY_FILE
  3. Run the app again, note that the app does not crash and the file is downloaded again during the next sync

Internal references:

Software Engineering Expectations
Technical Design Template

@subsymbolic subsymbolic requested a review from brindy October 9, 2018 01:19
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@subsymbolic subsymbolic merged commit 5f74578 into develop Oct 9, 2018
@subsymbolic subsymbolic deleted the feature/verifyBloomBeforeLoad branch October 9, 2018 09:17
CDRussell pushed a commit that referenced this pull request Mar 7, 2024
Task/Issue URL:
https://app.asana.com/0/1206787859054349/1206787859054349
Autoconsent Release:
https://github.com/duckduckgo/autoconsent/releases/tag/v10.2.0


## Description
Updates Autoconsent to version
[v10.2.0](https://github.com/duckduckgo/autoconsent/releases/tag/v10.2.0).

### Autoconsent v10.2.0 release notes
#### 🚀 Enhancement

- feat: support coca-cola.com using OneTrust
[#376](duckduckgo/autoconsent#376)
([@seia-soto](https://github.com/seia-soto))

#### 🔩 Dependency Updates

- Bump the dev-dependencies group with 4 updates
[#385](duckduckgo/autoconsent#385)
([@dependabot[bot]](https://github.com/dependabot[bot]))

#### Authors: 2

- [@dependabot[bot]](https://github.com/dependabot[bot])
- HoJeong Go ([@seia-soto](https://github.com/seia-soto))


## Steps to test
This release has been tested during Autoconsent development. You can
check the release notes for more information.

Co-authored-by: muodov <muodov@users.noreply.github.com>
joshliebe pushed a commit that referenced this pull request Mar 11, 2024
Task/Issue URL:
https://app.asana.com/0/1206787859054349/1206787859054349
Autoconsent Release:
https://github.com/duckduckgo/autoconsent/releases/tag/v10.2.0


## Description
Updates Autoconsent to version
[v10.2.0](https://github.com/duckduckgo/autoconsent/releases/tag/v10.2.0).

### Autoconsent v10.2.0 release notes
#### 🚀 Enhancement

- feat: support coca-cola.com using OneTrust
[#376](duckduckgo/autoconsent#376)
([@seia-soto](https://github.com/seia-soto))

#### 🔩 Dependency Updates

- Bump the dev-dependencies group with 4 updates
[#385](duckduckgo/autoconsent#385)
([@dependabot[bot]](https://github.com/dependabot[bot]))

#### Authors: 2

- [@dependabot[bot]](https://github.com/dependabot[bot])
- HoJeong Go ([@seia-soto](https://github.com/seia-soto))


## Steps to test
This release has been tested during Autoconsent development. You can
check the release notes for more information.

Co-authored-by: muodov <muodov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants