Feature/webview file deletion on data clear #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is partly to ensure that the cookies DB journal file is also cleared up upon data clearing, and helps ensure no sensitive browsing data is retained on the device after the data has been cleared
We are implementing the deletion in the same way as Firefox Focus here, who don't touch this directory or its contents as they observed disk caching would be disabled altogether if you do modify it.
subsymbolic
reviewed
Jun 17, 2019
Contributor
subsymbolic
left a comment
subsymbolic
left a comment
There was a problem hiding this comment.
Great work. I have one comment, however given the importance of this I don't want to block a release. I'm happy to proceed provided the feedback is addressed today too.
subsymbolic
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1126987722969423
Tech Design URL:
CC:
Description:
Performs cleanup on remaining files after the data has been cleared using the 🔥 button
Steps to test this PR:
ℹ️ Can only replicate the non-empty
Cookie-journalfile onMarshmallowandLollipop, so ensure you use one of these emulators for your testing.on develop, run these steps to ensure you can replicate the problem (to confirm the problem is definitely fixed):
adb pull data/data/com.duckduckgo.mobile.android/app_webviewCookies-journalfile; verify you can see cnn.com cookiesnow, checkout this branch, and repeat the steps above. this time, on the final step above, verify that the
Cookies-journalno longer exists (it will be re-created when theWebViewnext accepts a cookie)Additionally, check the general cookie handling works as you'd expect:
Internal references:
Software Engineering Expectations
Technical Design Template