Feature/cleaner api for clearing data #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of github.com:duckduckgo/Android into feature/cleaner_api_for_clearing_data # Conflicts: # app/src/main/java/com/duckduckgo/app/browser/WebDataManager.kt
subsymbolic
approved these changes
Jun 21, 2019
Contributor
|
Great work, that's much cleaner. Can we update the Asana task name to match the PR title? I think the title here better captures the work you've done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1127379946457993
Tech Design URL:
CC:
Description:
Tidying up data clearing APIs, as follow up work to feedback given in PR #513
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template