Autofill service fallback FF #5836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDRussell
reviewed
Mar 31, 2025
| autofillJob += coroutineScope.launch(dispatcherProvider.io()) { | ||
| runCatching { | ||
| if (autofillServiceFeature.self().isEnabled().not()) { | ||
| if (isAutofillServiceEnabled()) { |
cmonfortep
force-pushed
the
feature/cristian/autofill/add_ff_guard
branch
from
76cdbd6 to
130b239
Compare
CDRussell
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1149059203486286/1209843796003365/f
Description
See: https://app.asana.com/0/488551667048375/1209843796003365/f
TLDR; adds an extra fallback FF in case we can't rely on the parent FF
Steps to test this PR
N/A
UI changes