Skip to content

Autofill service fallback FF #5836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Autofill service fallback FF #5836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...utofill-impl/src/main/java/com/duckduckgo/autofill/impl/service/AutofillServiceFeature.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,7 @@ interface AutofillServiceFeature {
@Toggle.DefaultValue(false)
@InternalAlwaysEnabled
fun canAutofillInsideDDG(): Toggle

@Toggle.DefaultValue(true)
fun canProcessSystemFillRequests(): Toggle
}
6 changes: 5 additions & 1 deletion ...l/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/service/RealAutofillService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class RealAutofillService : AutofillService() {

autofillJob += coroutineScope.launch(dispatcherProvider.io()) {
runCatching {
if (autofillServiceFeature.self().isEnabled().not()) {
if (isAutofillServiceEnabled().not()) {
callback.onSuccess(null)
return@launch
}
Expand Down Expand Up @@ -169,6 +169,10 @@ class RealAutofillService : AutofillService() {
Timber.v("DDGAutofillService onDisconnected")
}

private fun isAutofillServiceEnabled(): Boolean {
return autofillServiceFeature.self().isEnabled() && autofillServiceFeature.canProcessSystemFillRequests().isEnabled()
}

companion object {
private val DDG_PACKAGE_IDS = setOf(
"com.duckduckgo.mobile.android",
Expand Down
Loading