add pixel for fire button pressed #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brindy
requested review from
CDRussell,
marcosholgado and
subsymbolic
as code owners
Member
|
Should it also trigger from the tab switcher activity? |
Contributor
Author
|
Probably! I need to do that on iOS as well then. Good shout. |
Contributor
Author
|
Updated with unique pixels. Will update Grafana also. |
CDRussell
approved these changes
Oct 31, 2019
Contributor
Author
|
Thanks @CDRussell ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/392891325557410/1147336208469615
Tech Design URL:
CC:
Description:
Adds a pixel for when the fire button is pressed so we can see what level of conversion there is.
Steps to test this PR:
mf.bppixel.mf.tppixel.Internal references:
Software Engineering Expectations
Technical Design Template