Cancel animations on rotation #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosholgado
requested review from
CDRussell and
subsymbolic
as code owners
CDRussell
reviewed
Dec 20, 2019
app/src/main/java/com/duckduckgo/app/onboarding/ui/page/WelcomePage.kt
Outdated
Show resolved
Hide resolved
CDRussell
reviewed
Dec 20, 2019
app/src/main/java/com/duckduckgo/app/onboarding/ui/page/WelcomePage.kt
Outdated
Show resolved
Hide resolved
CDRussell
approved these changes
Dec 20, 2019
marcosholgado
deleted the
bug/marcos/cancel_welcome_animation_on_rotation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/608920331025315/1154793601732017
Tech Design URL:
CC:
Description:
App crashes during the welcome screen if a rotation is performed at the correct time
Steps to test this PR:
mevariant.Internal references:
Software Engineering Expectations
Technical Design Template