Skip to content

Cancel animations on rotation #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2019
Merged

Cancel animations on rotation #654

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37ff73b
Cancel animations on rotation
marcosholgado Dec 20, 2019
c92f8b8
Refactor code
marcosholgado Dec 20, 2019
7fd79d3
Tidy up code
marcosholgado Dec 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions app/src/main/java/com/duckduckgo/app/onboarding/ui/page/WelcomePage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import android.view.View
import android.view.WindowManager
import androidx.core.content.ContextCompat
import androidx.core.view.ViewCompat
import androidx.core.view.ViewPropertyAnimatorCompat
import com.duckduckgo.app.browser.R
import com.duckduckgo.app.global.view.html
import kotlinx.android.synthetic.main.include_dax_dialog_cta.*
Expand All @@ -33,6 +34,8 @@ import kotlinx.android.synthetic.main.content_onboarding_welcome.longDescription
class WelcomePage : OnboardingPageFragment() {

private var ctaText: String = ""
private var welcomeAnimation: ViewPropertyAnimatorCompat? = null
private var typingAnimation: ViewPropertyAnimatorCompat? = null

override fun layoutResource(): Int = R.layout.content_onboarding_welcome

Expand All @@ -50,6 +53,12 @@ class WelcomePage : OnboardingPageFragment() {
applyFullScreenFlags()
}

override fun onDestroy() {
super.onDestroy()
welcomeAnimation?.cancel()
typingAnimation?.cancel()
}

private fun applyFullScreenFlags() {
activity?.window?.apply {
clearFlags(WindowManager.LayoutParams.FLAG_TRANSLUCENT_STATUS)
Expand All @@ -74,12 +83,12 @@ class WelcomePage : OnboardingPageFragment() {
}

private fun beginWelcomeAnimation(ctaText: String) {
ViewCompat.animate(welcomeContent as View)
welcomeAnimation = ViewCompat.animate(welcomeContent as View)
.alpha(MIN_ALPHA)
.setDuration(ANIMATION_DURATION)
.setStartDelay(ANIMATION_DELAY)
.withEndAction {
ViewCompat.animate(daxCtaContainer)
typingAnimation = ViewCompat.animate(daxCtaContainer)
.alpha(MAX_ALPHA)
.setDuration(ANIMATION_DURATION)
.withEndAction {
Expand Down