Skip to content

Conversation

@jainsahab
Copy link
Contributor

@jainsahab jainsahab commented Dec 26, 2019

Task/Issue URL: #400
Tech Design URL:
CC: @subsymbolic @marcosholgado @CDRussell @christophergeiger3

Description:
After this change, whenever browser user is initiating any download, a confirm popup will appear on the screen to confirm or deny the download. If the same file is already downloaded, the user will be presented with options like Keep both, Replace and Open with to open an existing file and abandon the download.

image

image

In the second iteration, we can also provide an option to the user where he/she can provide a custom name for the downloaded file.

Steps to test this PR:

  1. Open any sample file link such as https://www.antennahouse.com/XSLsample/pdf/sample-link_1.pdf

Internal references:

Software Engineering Expectations
Technical Design Template

@subsymbolic
Copy link
Contributor

subsymbolic commented Jan 6, 2020

Thanks for a great contribution @jainsahab. We'll need to make some small icon / UI tweaks so I'll speak to our product team and get back to you with details as well as a PR review.

@jainsahab
Copy link
Contributor Author

Sure @subsymbolic , Thanks a lot for acknowledgement. Let me know whenever you have mock-ups and feedback on code ready.

@duckduckgo duckduckgo deleted a comment from cd1063 Jan 7, 2020
@duckduckgo duckduckgo deleted a comment from cd1063 Jan 7, 2020
@jainsahab
Copy link
Contributor Author

Hi @subsymbolic , Just wanted to know about the status of this PR. are UI and icons finalized ?

Thanks,

@subsymbolic
Copy link
Contributor

Hi @jainsahab, hopefully our product team will have some time to look at his next week.

@subsymbolic
Copy link
Contributor

Thank you so much for you patience, we now have a design for you 🎉
design

Check out sheet_fire_clear_data.xml file for a similar dialog that we show when the user presses the fire button. This one also has the cancel button that you can reuse here.

The new vector assets are available at https://gist.github.com/subsymbolic/f16d4c275bb871fdfca0424307b2f525.

Let me know if you have any questions!

@jainsahab
Copy link
Contributor Author

Hi @subsymbolic , I am done with my changes, Let me know if you have any feedback.

image

@jainsahab
Copy link
Contributor Author

Hi @subsymbolic , could you please have a look at this PR, otherwise we might get more conflicts and the PR would need more work.

@subsymbolic
Copy link
Contributor

Definitely! Apologies for the delay, I have time to push this forward from Wednesday to Friday this week.

@jainsahab
Copy link
Contributor Author

Hi @subsymbolic , I've resolved the conflicts as of now. Let me know about your feedback when you get hold of it.

Copy link
Contributor

@subsymbolic subsymbolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you patience, I now have the time to give this the attention it needs! This is looking great, getting really close now. I have added my feedback inline.

@jainsahab
Copy link
Contributor Author

Hi @subsymbolic , Thanks for reviewing the code. I have incorporated all the feedback mentioned.

@jainsahab
Copy link
Contributor Author

Hi @subsymbolic , I really appreciate your efforts to take time out of your busy schedule and reviewing community's PR like this. Could you please finish this PR also, I are already done with the feedback and have resolved conflicts two times since then. Thanks,

Copy link
Contributor

@subsymbolic subsymbolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, I have sent it over to our product team for approval. There are a few final small PR comments, once they are done and we have product approval we can merge this.

@subsymbolic subsymbolic changed the base branch from develop to feature/multiple_authors/download_confirmation March 26, 2020 15:24
@subsymbolic subsymbolic merged commit 1edeac5 into duckduckgo:feature/multiple_authors/download_confirmation Mar 26, 2020
@subsymbolic
Copy link
Contributor

The code looks good, great work 🎉

Our product team has also come back and is happy to proceed however they don't want to show this dialog when we have already shown our own confirmation, such as when a user long-presses and requests to download an image. As this is a new request, I am accepting your PR in a feature branch and once we have implemented the newly requested dialog behavior, we will release both together.

Thanks for all your work on this 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants