Skip to content

Conversation

@AndrewR8
Copy link
Contributor

@AndrewR8 AndrewR8 commented Apr 5, 2020

Issue URL: #753

Steps to test this PR:

  1. Navigate to http://www.granditaliaperth.co.uk/menus.html and click on the download link for the menu.
  2. The download will start and a new blank tab closes immediately

@subsymbolic
Copy link
Contributor

Many thanks for submitting this, we really appreciate it. Unfortunately an earlier PR #663 has now been merged and clashes with your approach. If you get up to speed with the develop branch you'll see that closing the extra tab also dismisses the new download confirmation dialog.

If you want to try implementing a different solution, you are most welcome to update this PR. If not, that's ok too, just close this PR.

@AndrewR8
Copy link
Contributor Author

DownloadConfirmationFragment is attached to BrowserTabFragment. It looks like there are only two available solutions :

  1. Attach DownloadConfirmationFragment to Activity (If empty tab should be closed)

  2. Empty tab will be open until user dismisses DownloadConfirmationFragment

I need your advice.

@subsymbolic
Copy link
Contributor

Solution 1 sounds good 👍

…develop

# Conflicts:
#	app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt
@AndrewR8
Copy link
Contributor Author

I'll open a new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants