Skip to content

Conversation

@nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Nov 5, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1211755920811451/task/1211842214579233?focus=true

Description

Calculate savings dynamically from product details fetched

Steps to test this PR

Pre steps

Upgrade

  • Install from branch
  • Purchase a test monthly subscription (Free Trial)
  • Cancel and wait until Free Trial expires OR wait until free trial is renewed to a paid monthly subscription
  • If expired after canceled, purchase a monthly subscription again
  • Go to Subscription Settings
  • Check Switch option is there with updated text "Switch to Yearly and Save 17%"
  • Select Switch option
  • Check copy for upgrade option is correct (17%)

Downgrade

  • Switch to yearly
  • Wait until screen refreshes
  • Select switch option
  • Check copy for downgrade option is correct (17%)

No UI changes

@nalcalag nalcalag changed the base branch from feature/noelia/dynamic_discount_smartling to develop November 5, 2025 13:51
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I have another branch to handle translations

Copy link
Contributor

@lmac012 lmac012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nalcalag nalcalag changed the base branch from develop to feature/noelia/dynamic_discount_smartling November 6, 2025 11:30
Base automatically changed from feature/noelia/dynamic_discount_smartling to develop November 7, 2025 16:57
@nalcalag nalcalag force-pushed the feature/noelia/dynamic_discount_implementation branch from 6003c1b to eee46d0 Compare November 7, 2025 18:12
@nalcalag nalcalag merged commit e7c6d56 into develop Nov 7, 2025
6 checks passed
@nalcalag nalcalag deleted the feature/noelia/dynamic_discount_implementation branch November 7, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants