SERP Settings Sync: Add and update pixels #7073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikescamell
force-pushed
the
feature/mike/serp-settings-sync/open-duck-ai-pixel
branch
2 times, most recently
from
f3afcfb to
6e5ebf2
Compare
mikescamell
commented
Nov 19, 2025
| DUCK_CHAT_EXPERIMENTAL_ADDRESS_BAR_IS_ENABLED_DAILY.pixelName to PixelParameter.removeAtb(), | ||
| DUCK_CHAT_SEARCH_ASSIST_SETTINGS_BUTTON_CLICKED.pixelName to PixelParameter.removeAtb(), | ||
| DUCK_CHAT_HIDE_AI_GENERATED_IMAGES_BUTTON_CLICKED.pixelName to PixelParameter.removeAtb(), | ||
| SERP_SETTINGS_OPEN_HIDE_AI_GENERATED_IMAGES.pixelName to PixelParameter.removeAtb(), |
Contributor
Author
There was a problem hiding this comment.
Do we want to move this to the settings module even though it's only fired here?
If we do then we'll need to make an API proposal to expose it.
I'm not sure it's worth it, we only renamed it to match other platforms.
Contributor
There was a problem hiding this comment.
I think is fine leaving it here
mikescamell
changed the title
serp_settings_open_hide-ai-generated-images is going to replace an existing pixel name serp_settings_open_duck-ai is new
Add our own plugin so we're not using app's PixelInterceptor
mikescamell
force-pushed
the
feature/mike/serp-settings-sync/open-duck-ai-pixel
branch
from
6e5ebf2 to
824bbce
Compare
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1211991948393724 |
mikescamell
changed the title
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
14 tasks
mikescamell
deleted the
feature/mike/serp-settings-sync/open-duck-ai-pixel
branch
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1211846254913290?focus=true
Description
Added and updated pixels for SERP settings sync work to match other platforms.
serp_settings_open_hide-ai-generated-imagesis going to replace an existing pixel nameHide Ai Generatedoption is opened and highlighted in SERP settings.serp_settings_open_duck-aiis newSteps to test this PR
serp_settings_open_hide-ai-generated-imagespixel is fired and no ATBserp_settings_open_duck-aipixel is fired with no ATB and you're taken to the AI Features settings page