Skip to content

Conversation

@mikescamell
Copy link
Contributor

@mikescamell mikescamell commented Nov 19, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1211992919877851?focus=true

Description

This PR adds a url parameter to hide the "Duck.ai" toggle when opening SERP settings from Native Settings.

Screen_recording_20251119_222406.mp4

Steps to test this PR

Apply the patch found here:

SERP Duck.ai toggle hidden

  • Enable the hideAiGeneratedImagesOption feature flag
  • Open "AI Features" in Native Settings
  • Click "Search Assist Settings"
  • Scroll up
  • The SERP Duck.ai toggle should not be visible
  • Press back
  • Click "Hide AI generated Images"
  • Scroll up
  • The SERP Duck.ai toggle should not be visible

Feature Flag off behaviour

  • Remove the patch
  • Disable the hideAiGeneratedImagesOption feature flag (you may need to remove @InternalAlwaysEnabled from the feature toggle in code)
Index: settings/settings-api/src/main/java/com/duckduckgo/settings/api/SettingsPageFeature.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/settings/settings-api/src/main/java/com/duckduckgo/settings/api/SettingsPageFeature.kt b/settings/settings-api/src/main/java/com/duckduckgo/settings/api/SettingsPageFeature.kt
--- a/settings/settings-api/src/main/java/com/duckduckgo/settings/api/SettingsPageFeature.kt	(revision 52449652d832b0bfe59caed749e6d7eb76a8d9a6)
+++ b/settings/settings-api/src/main/java/com/duckduckgo/settings/api/SettingsPageFeature.kt	(date 1763588843129)
@@ -32,7 +32,6 @@
     fun embeddedSettingsWebView(): Toggle
 
     @Toggle.DefaultValue(DefaultFeatureValue.FALSE)
-    @Toggle.InternalAlwaysEnabled
     fun hideAiGeneratedImagesOption(): Toggle
 
     @Toggle.DefaultValue(DefaultFeatureValue.FALSE)
  • Open "AI Features" in Native Settings
  • Click "Search Assist Settings"
  • The SERP Duck.ai toggle should be visible

UI changes

No UI changes, only backend URL and logic updates.

Copy link
Contributor Author

mikescamell commented Nov 19, 2025

@mikescamell mikescamell force-pushed the feature/mike/serp-settings-sync/hide-duck-ai-serp-setting branch from 07f1576 to 5244965 Compare November 19, 2025 21:48
Base automatically changed from feature/mike/serp-settings-sync/open-duck-ai-pixel to develop November 19, 2025 22:00
@mikescamell mikescamell force-pushed the feature/mike/serp-settings-sync/hide-duck-ai-serp-setting branch from 5244965 to 1800d4f Compare November 19, 2025 22:43
@mikescamell mikescamell marked this pull request as ready for review November 19, 2025 22:45
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikescamell mikescamell merged commit cead15b into develop Nov 20, 2025
15 checks passed
@mikescamell mikescamell deleted the feature/mike/serp-settings-sync/hide-duck-ai-serp-setting branch November 20, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants