Insert DefaultBrowser Cta and SearchWidget Cta as Dax dialog during Dax Journey #716

cmonfortep · 2020-02-19T13:21:23Z

Task/Issue URL: https://app.asana.com/0/488551667048375/1161278038072567/f
Tech Design URL:
CC:

Description:
In this experiment we are going to place our CTAs inside our Dax Journey. Our CTAs will match the style/tone of the existing Dax dialogs.

Default Browser CTA: After the user visits a site with trackers, we prompt a Dax dialog to tell the user that we blocked all the trackers in that site. After showing that dialog we will ask the user to set us as Default browser.
Search Widget CTA: When the user visits DuckDuckGo, a Dax dialog will appear informing our users that all their searches are private. After showing that dialog we will ask the user to add our search widget to protect their future searches.

Concept test variant mj: Vanila concept test

Hardcode into variantManager variant "mj"
Perform a fresh install
Run the app and ensure onboarding doesn't show any cta
Visit a web with trackers like cnn.com
Ensure dax dialog appears informing about trackers found
Click on "High five!"
Ensure no more Ctas are shown
Visit duckduckgo.com
Ensure dax dialog appears
Click on "Phew!"
Ensure no more Ctas are shown

Concept test variant ml: Concept test with old ctas

Hardcode into variantManager variant "ml"
Perform a fresh install
Run the app and ensure during the onboarding Default browser cta appears
Visit a web with trackers like cnn.com
Ensure dax dialog appears informing about trackers found
Click on "High five!"
Ensure no more Ctas are shown
Visit duckduckgo.com
Ensure dax dialog appears
Click on "Phew!"
Ensure no more Ctas are shown
Continue the Dax journey till the end (open new tab, visit a website, open a new tab)
Ensure Search widget cta appears in home screen

Concept test variant mh: concept test with ctas as dax dialogs:

Dax Default Browser cta:

Test-1

Hardcode into variantManager variant "mh"
Perform a fresh install
Run the app and ensure onboarding doesn't show any default browser cta
Visit a web with trackers like cnn.com
Ensure dax dialog appears informing about trackers found
Click on "High five!"
Ensure DefaultBrowser cta appears
Ensure pixel "m_odc_s" is fired with "dbd" as param
Click on "Ok"
Ensure pixel "m_odc_ok" is fired with "dbd" as param
Ensure Dialog asking to set ddg as default browser appears

Repeat each of the following scenarios with previous steps:

a)
12. Click on "just once"
13. Ensure dialog appears again
14. Ensure no pixel is fired
14. Click on "always"
15. Ensure dialog dissapears
16. Ensure pixel "m_db_s" is fired with "dbo=d" as param

b)
12. Click on "just once"
13. Ensure dialog appears again
14. Click on "always"
15. Ensure dialog dissapears
16. Ensure pixel "m_db_ns" is fired with "dbo=jom" as param

c)
12. press back
13. Ensure dialog is dismissed
14. Ensure pixel "m_db_ns" is fired with "dbo=dd" as param

d)
12. select another browser and click "always"
13. Go back to DDG app
14. Ensure dialog is dismissed
14. Ensure pixel "m_db_ns" is fired with "dbo=e" as param

Test-2

Hardcode into variantManager variant "mh"
Perform a fresh install
Go to settings and set as another browser as default
Run the app and ensure onboarding doesn't show any default browser cta
Visit a web with trackers like cnn.com
Ensure dax dialog appears informing about trackers found
Click on "High five!"
Ensure DefaultBrowser cta appears
Ensure pixel "m_odc_s" is fired with "dbs" as param

Repeat each of the following scenarios with previous steps:

a)
10. Click on "Go to settings"
11. Ensure pixel "m_odc_ok" is fired with "dbs" as param
12. Ensure user navigates to settings
13. Select ddg as default browser
14. Go back to the app
15. Ensure pixel "m_db_s" is fired with "fo=false, dbo=s" as param
16. Ensure cta is gone

b)
10. Click on "Maybe later"
11. Ensure pixel "m_odc_c" is fired with "dbs" as param
12. Ensure cta is gone

Dax Search widget cta:

Test-1

Hardcode into variantManager variant "mh"
Perform a fresh install
Run the app and ensure onboarding doesn't show any default browser cta
Visit duckduckgo.com
Ensure dax dialog appears
Click on "Phew!"
Ensure SearchWidget cta appears
Ensure pixel "m_odc_s" is fired with "wa" as param
Click on "Add"
Ensure pixel "m_odc_ok" is fired with "wa" as param
Ensure cta is gone
Ensure dialog appears asking the user to add the search widget

Test-2

Hardcode into variantManager variant "mh"
Perform a fresh install
Run the app and ensure onboarding doesn't show any default browser cta
Visit duckduckgo.com
Ensure dax dialog appears
Click on "Phew!"
Ensure SearchWidget cta appears
Ensure pixel "m_odc_s" is fired with "wa" as param
Click on "Maybe later"
Ensure pixel "m_odc_c" is fired with "wa" as param
Ensure cta is gone

Test-3 (device running api < 23)

Hardcode into variantManager variant "mh"
Perform a fresh install
Run the app and ensure onboarding doesn't show any default browser cta
Visit duckduckgo.com
Ensure dax dialog appears
Click on "Phew!"
Ensure no cta appears

Test-4 (device running api 23/24/26)

Hardcode into variantManager variant "mh"
Perform a fresh install
Run the app and ensure onboarding doesn't show any default browser cta
Visit duckduckgo.com
Ensure dax dialog appears
Click on "Phew!"
Ensure SearchWidget cta appears
Ensure pixel "m_odc_s" is fired with "wm" as param
Click on "Add"
Ensure pixel "m_odc_ok" is fired with "wm" as param
Ensure cta is gone
Ensure dialog appears showing the user how to add the search widget

Internal references:

Software Engineering Expectations
Technical Design Template

…Livedata. * This will remove a race condition bug when showing a new cta right after dismiss the previous one. Dismiss happens after a new cta has been emitted via livedata.

…alog class. Not all Dax dialogs use view highlighting.

This hierarchy will be changed.

…dget cta

…ialog Refacto dax dialog layout to use linearlayout instead of constraint layout

…n secondary button is clicked. Use same dialog when it has one or two buttons. Segregated logic only applies for dialogs highlighting a view.

Removing one layer of ConstraintLayout for one LinearLayout to simplify working with margins between buttons.

… from SecondaryButtonCta

* Introduce new logic to show/hide a secondaryButton on DaxDialogs. * Change DaxDialog creation logic inside Cta. * Adapt BrowserTabFragment listener logic to new chanes.

…ian/cta_concept_test_2 # Conflicts: # app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt # app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt # app/src/main/java/com/duckduckgo/app/cta/ui/Cta.kt # app/src/main/res/layout/content_dax_dialog.xml # app/src/main/res/values/attrs.xml # app/src/main/res/values/themes.xml

* show toast and background view to help user decide * if user clicks just once, we prompt the dialog again * navigation to settings extracted to a new class * Toast instructions extracted to a new class * Changed instructions card margins to mirror toolbar size * Show card only if ddg is not default browser

…r clicks on some Dax dialogs primary button

* Remove allocating users before referrer delay * Referrer variant is now based on DEFAULT_VARIANT * Adapt tests to new changes

This reverts commit 48ba2a7.

* Renamed some features making explicit to what part of the app they are related * Update test accordingly

…xp2' into feature/cristian/cta_concept_test_2

…feature/cristian/cta_concept_test_2 # Conflicts: # app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt # app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt

marcosholgado

Few things while testing this:

Dismissing the dialog sends dbo=dxdd but selecting another browser and coming back to DDG also sends dbo=dxdd. When analyzing this you won’t be able to know if the user selected a different browser or if they just dimissed the dialog. We used to send dbo=e for any external browser selected, you might want to consider this.

All the references in the description to m_db_s say the parameter sent should be dxdfs or dxdfd but we are sending dxs (no dx prefix), I guess is a typo in the description but better to double check.

This is my personal opinion so feel free to ignore this. I think the params being dxdfs, etc are a bit long. Consider shortening them to maybe ds for dialog settings, etc. I wrote a comment about it as well.

Tapping on the trackers blocked dialog while the typing animation is running dismisses the dialog instead of finishing the animation. This kills the default browser cta and probably got broken while doing the 2 buttons cta work.

There is a bug we talked about before where the instructions card is not aligned with the custom toast on the default browser page but we can ignore this until the experiment comes back with some results but we may want to keep a task to fix this in case we end up keeping that screen.

app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

app/src/main/java/com/duckduckgo/app/statistics/pixels/Pixel.kt

app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt

app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt

app/src/androidTest/java/com/duckduckgo/app/cta/ui/CtaViewModelNextCtaTest.kt

app/src/androidTest/java/com/duckduckgo/app/cta/ui/CtaViewModelTest.kt

app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

…feature/cristian/cta_concept_test_2

…wser dialog

* Making shorter the value of CTA pixel params * Update unit tests accordingly

…issed

…feature/cristian/cta_concept_test_2

cmonfortep · 2020-02-24T22:38:55Z

Thanks for the review @marcosholgado

I added the logic to detect when the user has selected another browser from the dialog following your advice. Thanks, good point there.
AND
Changed the pixelName values to make them shorter, and also removed the ones I added. Now I use the existing ones from the onboarding. I updated the description fixing the cases I wrongly described and adding a new one for the external browser.
Fixed dismissing the dialog when the user clicks before the animation is finished.
The bug related to the instructions card I left it out of this scope and I will create a side task for that.

marcosholgado

Looking good! Thanks for the changes.

We discussed making another change for the dbo=e pixel to avoid a very edge case where the app gets backgrounded while the dialog is being shown and the user dismisses the dialog, in that case we receive dbo=e rather than dbo=dd but that can also happen with other edge cases and doesn't seem to be a clean solution when the user selects another browser as just once.

Feel free to merge once you figure out what you want to do with it, i.e remove dbo=e in the external browser just once scenario or any other solutions :)

* Dax dialog with two buttons (#713) * New variant: Showing DefaultBrowserCta and SearchWidgetCta as Dax dialogs (#714) * Insert DefaultBrowser Cta and SearchWidget Cta as Dax dialog during Dax Journey (#716) * New control group and changes on when to show search widget cta (#723)

cmonfortep added 30 commits February 12, 2020 20:52

create defaultBrowser dax dialog

ee31fe5

show defaultBrowser cta after TrackersBlockedCta

2ec29f9

When dismiss a cta, rely on dimissed cta instead of current value in …

db3624f

…Livedata. * This will remove a race condition bug when showing a new cta right after dismiss the previous one. Dismiss happens after a new cta has been emitted via livedata.

Separate implementation details of view highlighting from base Dax di…

d048261

…alog class. Not all Dax dialogs use view highlighting.

Dax dialog with 2 buttons, duplicated version.

e169330

This hierarchy will be changed.

Created functional dax dialogs with default browser cta and search wi…

8d5b9a5

…dget cta

show instructions card when user is prompted with defaultbrowser as d…

e06b1d8

…ialog Refacto dax dialog layout to use linearlayout instead of constraint layout

New interface for Ctas with a secondary button and pixel tracking whe…

dda1ae9

…n secondary button is clicked. Use same dialog when it has one or two buttons. Segregated logic only applies for dialogs highlighting a view.

Rename Events produced from some ctas to Actions.

e8d06b9

syntax: replace if for when

e219fda

Theming new values to be used in dax dialog secondary button

afc6f48

Daxdialog layout changes to simplify required design.

927d345

Removing one layer of ConstraintLayout for one LinearLayout to simplify working with margins between buttons.

Send pixels when secondary button is clicked using secondaryPixelName…

704af49

… from SecondaryButtonCta

When user clicks on secondary button, notify CtaViewModel

d9d5b3d

* Detach highlighting logic from normal DaxDialogs.

b847031

* Introduce new logic to show/hide a secondaryButton on DaxDialogs. * Change DaxDialog creation logic inside Cta. * Adapt BrowserTabFragment listener logic to new chanes.

Avoid showing a dark statusbar when dialog is shown

5227754

Move to background thread logic related to showing next Cta after use…

886015a

…r clicks on some Dax dialogs primary button

Make consistent method names for primaryAction inside different Ctas

e77fc3e

Make concept test new default variant.

48ba2a7

* Remove allocating users before referrer delay * Referrer variant is now based on DEFAULT_VARIANT * Adapt tests to new changes

Revert "Make concept test new default variant."

9f58795

This reverts commit 48ba2a7.

Introducing new variants for second experiment.

1921877

* Renamed some features making explicit to what part of the app they are related * Update test accordingly

Avoid allocating users before referrer logic has been executed.

3ed4364

remove previous control group

10208a9

Update active variants with new keys

91ace86

pixel to be used for our dax default browser cta

92df358

(wip) logic to send pixels for dax default browser cta

10e9d4c

Merge branch 'feature/cristian/new_variants_insert_cta_concept_test_e…

ad3d8dd

…xp2' into feature/cristian/cta_concept_test_2

Fence new dax dialogs ctas based on variantmanager

a2fe81b

cmonfortep requested review from CDRussell, marcosholgado and subsymbolic as code owners February 19, 2020 23:02

fix correct pixel param value in test

b76fc63

marcosholgado self-assigned this Feb 20, 2020

cmonfortep added 2 commits February 21, 2020 10:24

Copy update

1e9ddcb

Merge branch 'feature/cristian/fb_insert_cta_concept_test_exp2' into …

b636571

…feature/cristian/cta_concept_test_2 # Conflicts: # app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt # app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt

marcosholgado requested changes Feb 21, 2020

View reviewed changes

cmonfortep added 11 commits February 22, 2020 15:29

Merge branch 'feature/cristian/fb_insert_cta_concept_test_exp2' into …

91dc196

…feature/cristian/cta_concept_test_2

Renamed commands to be explicit of their actions

5f1e740

remove unused imports

992b949

Fix test names describing a wrong scenario

e9ff584

fix typo

30c1ff2

Fire expected pixel when user chooses another browser from DefaultBro…

3fbc0d5

…wser dialog

* Remove duplicated pixel values.

d3f3e1e

* Making shorter the value of CTA pixel params * Update unit tests accordingly

Fix: when user taps in dialog before animation ends, dialog gets dism…

9ab2988

…issed

Putting back expected variants weights

b7c6adc

organize imports

195f3f9

Merge branch 'feature/cristian/fb_insert_cta_concept_test_exp2' into …

c0907c3

…feature/cristian/cta_concept_test_2

cmonfortep requested a review from malmstein as a code owner February 24, 2020 21:58

cmonfortep requested a review from marcosholgado February 24, 2020 22:33

marcosholgado approved these changes Feb 25, 2020

View reviewed changes

Track dbo=e only when user selects another browser as default

ddc52ef

cmonfortep merged commit 77fe816 into feature/cristian/fb_insert_cta_concept_test_exp2 Feb 25, 2020

cmonfortep deleted the feature/cristian/cta_concept_test_2 branch February 25, 2020 20:53

This was referenced Feb 26, 2020

New control group and changes on when to show search widget cta #723

Merged

Insert CTAs on concept test Experiment#2 #724

Merged

cmonfortep mentioned this pull request Mar 14, 2020

Quick Search Notification Experiment #742

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Insert DefaultBrowser Cta and SearchWidget Cta as Dax dialog during Dax Journey #716

Insert DefaultBrowser Cta and SearchWidget Cta as Dax dialog during Dax Journey #716

Uh oh!

cmonfortep commented Feb 19, 2020 •

edited

Loading

Uh oh!

marcosholgado left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cmonfortep commented Feb 24, 2020 •

edited

Loading

Uh oh!

marcosholgado left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Insert DefaultBrowser Cta and SearchWidget Cta as Dax dialog during Dax Journey #716

Insert DefaultBrowser Cta and SearchWidget Cta as Dax dialog during Dax Journey #716

Uh oh!

Conversation

cmonfortep commented Feb 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Internal references:

Uh oh!

marcosholgado left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cmonfortep commented Feb 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcosholgado left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cmonfortep commented Feb 19, 2020 •

edited

Loading

cmonfortep commented Feb 24, 2020 •

edited

Loading