Insert CTAs on concept test Experiment#2 #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Daxdialog layout changes to simplify required design. Removing one layer of ConstraintLayout for one LinearLayout to simplify working with margins between buttons. * Avoid showing a dark statusbar when dialog is shown * Style created for each Dax dialog button.
…logs (#714) * Introducing new variants for second experiment. * Renamed some features making explicit to what part of the app they are related * Avoid allocating users before referrer logic has been executed.
…st_exp2 # Conflicts: # app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt # app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt
…ax Journey (#716) * create defaultBrowser dax dialog * show defaultBrowser cta after TrackersBlockedCta * When dismiss a cta, rely on dimissed cta instead of current value in Livedata. * Separate implementation details of view highlighting from base Dax dialog class. Not all Dax dialogs use view highlighting. * Created functional dax dialogs with default browser cta and search widget cta * Send pixels when secondary button is clicked using secondaryPixelName from SecondaryButtonCta * navigation to settings extracted to a new class * Toast instructions extracted to a new class * Introducing new variants for second experiment. * Avoid allocating users before referrer logic has been executed. * Fence new dax dialogs ctas based on variantmanager * Track dbo=e only when user selects another browser as default
…st_exp2 # Conflicts: # app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt # app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
* Moving as control group variant of concept test + CTAs * Removing from experiment concept test as control group * Show search widget cta only if at least one nonSerp Cta has been shown
cmonfortep
requested review from
CDRussell,
malmstein,
marcosholgado and
subsymbolic
as code owners
cmonfortep
deleted the
feature/cristian/fb_insert_cta_concept_test_exp2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1149059203486286/1161278038072567/f
Tech Design URL:
CC:
Description:
In this experiment we are going to place our CTAs inside our Dax Journey. Our CTAs will match the style/tone of the existing Dax dialogs.
Default Browser CTA: After the user visits a site with trackers, we prompt a Dax dialog to tell the user that we blocked all the trackers in that site. After showing that dialog we will ask the user to set us as Default browser.
Search Widget CTA: When the user visits DuckDuckGo, a Dax dialog will appear telling our users that all their searches are private. If the user has already seen a nonSerp CTA (where we explain to them how we will protect them), we will also ask the user to add our search widget. If the user has not visited any nonSerp site yet, we will show the search widget CTA on their next SERP visit.
Feature branch:
No need for a deep review here.
We are merging the following PRs that have been already reviewed and tested:
Internal references:
Software Engineering Expectations
Technical Design Template