Move getHeaders checks to io #7225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisBarreiro
force-pushed
the
feature/cris/anrs/move-getcustomheaders-to-io
branch
3 times, most recently
from
1eeb15b to
9ad4c91
Compare
daxmobile
reviewed
Nov 26, 2025
Collaborator
There was a problem hiding this comment.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:45:45: Double quote to prevent globbing and word splitting [shellcheck]
CrisBarreiro
force-pushed
the
feature/cris/anrs/move-getcustomheaders-to-io
branch
from
9ad4c91 to
4c25f92
Compare
CrisBarreiro
commented
Nov 26, 2025
Contributor
Author
There was a problem hiding this comment.
Only for testing, will revert later
CrisBarreiro
force-pushed
the
feature/cris/anrs/move-getcustomheaders-to-io
branch
5 times, most recently
from
bb15825 to
2525e6b
Compare
CDRussell
approved these changes
Nov 27, 2025
Member
CDRussell
left a comment
CDRussell
left a comment
There was a problem hiding this comment.
Approving; LGTM
A reminder to clean up the temporary changes to the maestro yamls
CrisBarreiro
force-pushed
the
feature/cris/anrs/move-getcustomheaders-to-io
branch
from
b6448f9 to
d261be8
Compare
CrisBarreiro
deleted the
feature/cris/anrs/move-getcustomheaders-to-io
branch
CrisBarreiro
added a commit
that referenced
this pull request
Nov 27, 2025
This reverts commit ec5d4b5.
CrisBarreiro
added a commit
that referenced
this pull request
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1212150079356362?focus=true
Description
Make methods in
CustomHeadersProvidersuspend, and ensure RC flag checks are done in io. Similarly, move some dataStore queries to io as well:Steps to test this PR
Feature 1
UI changes