Skip to content

Insert CTAs on concept test Experiment#2 #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 28, 2020
Merged

Insert CTAs on concept test Experiment#2 #724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a5f9839
Dax dialog with two buttons (#713)
cmonfortep Feb 19, 2020
3b0b83b
New variant: Showing DefaultBrowserCta and SearchWidgetCta as Dax dia…
cmonfortep Feb 19, 2020
120ef9e
Merge branch 'develop' into feature/cristian/fb_insert_cta_concept_te…
cmonfortep Feb 21, 2020
2b05909
Merge branch 'develop' into feature/cristian/fb_insert_cta_concept_te…
cmonfortep Feb 22, 2020
a577d6d
Merge branch 'develop' into feature/cristian/fb_insert_cta_concept_te…
cmonfortep Feb 24, 2020
77fe816
Insert DefaultBrowser Cta and SearchWidget Cta as Dax dialog during D…
cmonfortep Feb 25, 2020
eb6b22e
Merge branch 'develop' into feature/cristian/fb_insert_cta_concept_te…
cmonfortep Feb 27, 2020
5baeadc
New control group and changes on when to show search widget cta (#723)
cmonfortep Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
170 changes: 140 additions & 30 deletions app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import com.duckduckgo.app.browser.BrowserTabViewModel.Command.Navigate
import com.duckduckgo.app.browser.LongPressHandler.RequiredAction.DownloadFile
import com.duckduckgo.app.browser.LongPressHandler.RequiredAction.OpenInNewTab
import com.duckduckgo.app.browser.addtohome.AddToHomeCapabilityDetector
import com.duckduckgo.app.browser.defaultbrowsing.DefaultBrowserDetector
import com.duckduckgo.app.browser.favicon.FaviconDownloader
import com.duckduckgo.app.browser.model.BasicAuthenticationCredentials
import com.duckduckgo.app.browser.model.BasicAuthenticationRequest
Expand All @@ -52,6 +53,7 @@ import com.duckduckgo.app.cta.db.DismissedCtaDao
import com.duckduckgo.app.cta.model.DismissedCta
import com.duckduckgo.app.cta.ui.CtaViewModel
import com.duckduckgo.app.cta.ui.DaxBubbleCta
import com.duckduckgo.app.cta.ui.DaxDialogCta
import com.duckduckgo.app.cta.ui.HomePanelCta
import com.duckduckgo.app.global.db.AppDatabase
import com.duckduckgo.app.global.install.AppInstallStore
Expand Down Expand Up @@ -176,6 +178,9 @@ class BrowserTabViewModelTest {
@Mock
private lateinit var mockPrivacySettingsStore: PrivacySettingsStore

@Mock
private lateinit var mockDefaultBrowserDetector: DefaultBrowserDetector

private lateinit var mockAutoCompleteApi: AutoCompleteApi

private lateinit var ctaViewModel: CtaViewModel
Expand Down Expand Up @@ -208,7 +213,8 @@ class BrowserTabViewModelTest {
mockVariantManager,
mockSettingsStore,
mockOnboardingStore,
mockPrivacySettingsStore
mockPrivacySettingsStore,
mockDefaultBrowserDetector
)

val siteFactory = SiteFactory(mockPrivacyPractices, mockEntityLookup)
Expand Down Expand Up @@ -240,7 +246,9 @@ class BrowserTabViewModelTest {
searchCountDao = mockSearchCountDao,
pixel = mockPixel,
variantManager = mockVariantManager,
dispatchers = coroutineRule.testDispatcherProvider
dispatchers = coroutineRule.testDispatcherProvider,
defaultBrowserDetector = mockDefaultBrowserDetector,
installStore = mockAppInstallStore
)

testee.loadData("abc", null, false)
Expand Down Expand Up @@ -1361,7 +1369,7 @@ class BrowserTabViewModelTest {
@Test
fun whenSurveyCtaDismissedAndNoOtherCtaPossibleCtaIsNull() {
testee.onSurveyChanged(Survey("abc", "http://example.com", daysInstalled = 1, status = Survey.Status.SCHEDULED))
testee.onUserDismissedCta()
testee.onUserDismissedCta(testee.ctaViewState.value!!.cta!!)
assertNull(testee.ctaViewState.value!!.cta)
}

Expand All @@ -1372,7 +1380,7 @@ class BrowserTabViewModelTest {
whenever(mockWidgetCapabilities.hasInstalledWidgets).thenReturn(false)

testee.onSurveyChanged(Survey("abc", "http://example.com", daysInstalled = 1, status = Survey.Status.SCHEDULED))
testee.onUserDismissedCta()
testee.onUserDismissedCta(testee.ctaViewState.value!!.cta!!)
assertEquals(HomePanelCta.AddWidgetAuto, testee.ctaViewState.value!!.cta)
}

Expand Down Expand Up @@ -1467,75 +1475,171 @@ class BrowserTabViewModelTest {
@Test
fun whenUserClickedCtaButtonThenFirePixel() {
val cta = DaxBubbleCta.DaxIntroCta(mockOnboardingStore, mockAppInstallStore)
testee.ctaViewState.value = BrowserTabViewModel.CtaViewState(cta = cta)

testee.onUserClickCtaOkButton()
testee.onUserClickCtaOkButton(cta)
verify(mockPixel).fire(cta.okPixel!!, cta.pixelOkParameters())
}

@Test
fun whenUserClickedCtaButtonThenLaunchSurveyCommand() {
fun whenUserClickedSurveyCtaButtonThenLaunchSurveyCommand() {
val cta = HomePanelCta.Survey(Survey("abc", "http://example.com", daysInstalled = 1, status = Survey.Status.SCHEDULED))
testee.ctaViewState.value = BrowserTabViewModel.CtaViewState(cta = cta)

testee.onUserClickCtaOkButton()
testee.onUserClickCtaOkButton(cta)
assertCommandIssued<Command.LaunchSurvey>()
}

@Test
fun whenUserClickedCtaButtonThenLaunchAddWidgetCommand() {
fun whenUserClickedAddWidgetCtaButtonThenLaunchAddWidgetCommand() {
val cta = HomePanelCta.AddWidgetAuto
testee.ctaViewState.value = BrowserTabViewModel.CtaViewState(cta = cta)

testee.onUserClickCtaOkButton()
testee.onUserClickCtaOkButton(cta)
assertCommandIssued<Command.LaunchAddWidget>()
}

@Test
fun whenUserClickedCtaButtonThenLaunchLegacyAddWidgetCommand() {
fun whenUserClickedLegacyAddWidgetCtaButtonThenLaunchLegacyAddWidgetCommand() {
val cta = HomePanelCta.AddWidgetInstructions
testee.ctaViewState.value = BrowserTabViewModel.CtaViewState(cta = cta)
testee.onUserClickCtaOkButton(cta)
assertCommandIssued<Command.LaunchLegacyAddWidget>()
}

testee.onUserClickCtaOkButton()
@Test
fun whenUserClickedDefaultBrowserCtaButtonWithoutDefaultBrowserThenLaunchDialogCommand() {
whenever(mockDefaultBrowserDetector.hasDefaultBrowser()).thenReturn(false)
val cta = DaxDialogCta.DefaultBrowserCta(mockDefaultBrowserDetector, mock(), mock())
testee.onUserClickCtaOkButton(cta)
assertCommandIssued<Command.OpenDefaultBrowserDialog>()
}

@Test
fun whenUserClickedDefaultBrowserCtaButtonWithDefaultBrowserThenOpenDefaultBrowserSettings() {
whenever(mockDefaultBrowserDetector.hasDefaultBrowser()).thenReturn(true)
val cta = DaxDialogCta.DefaultBrowserCta(mockDefaultBrowserDetector, mock(), mock())
testee.onUserClickCtaOkButton(cta)
assertCommandIssued<Command.OpenDefaultBrowserSettings>()
}

@Test
fun whenUserClickedDaxSearchWidgetCtaButtonWithWidgetCapabilitiesThenLaunchAddWidget() {
whenever(mockWidgetCapabilities.supportsAutomaticWidgetAdd).thenReturn(true)
val cta = DaxDialogCta.SearchWidgetCta(mockWidgetCapabilities, mock(), mock())
testee.onUserClickCtaOkButton(cta)
assertCommandIssued<Command.LaunchAddWidget>()
}

@Test
fun whenUserClickedDaxSearchWidgetCtaButtonWithoutWidgetCapabilitiesThenLaunchLegacyAddWidget() {
whenever(mockWidgetCapabilities.supportsAutomaticWidgetAdd).thenReturn(false)
val cta = DaxDialogCta.SearchWidgetCta(mockWidgetCapabilities, mock(), mock())
testee.onUserClickCtaOkButton(cta)
assertCommandIssued<Command.LaunchLegacyAddWidget>()
}

@Test
fun whenUserDismissedCtaThenFirePixel() {
val cta = HomePanelCta.Survey(Survey("abc", "http://example.com", daysInstalled = 1, status = Survey.Status.SCHEDULED))
testee.ctaViewState.value = BrowserTabViewModel.CtaViewState(cta = cta)

testee.onUserDismissedCta()
testee.onUserDismissedCta(cta)
verify(mockPixel).fire(cta.cancelPixel!!, cta.pixelCancelParameters())
}

@Test
fun whenUserDismissedCtaThenRegisterInDatabase() {
val cta = HomePanelCta.AddWidgetAuto
testee.ctaViewState.value = BrowserTabViewModel.CtaViewState(cta = cta)

testee.onUserDismissedCta()
testee.onUserDismissedCta(cta)
verify(mockDismissedCtaDao).insert(DismissedCta(cta.ctaId))
}

@Test
fun whenUserDismissedSurveyCtaThenDoNotRegisterInDatabase() {
val cta = HomePanelCta.Survey(Survey("abc", "http://example.com", daysInstalled = 1, status = Survey.Status.SCHEDULED))
testee.ctaViewState.value = BrowserTabViewModel.CtaViewState(cta = cta)

testee.onUserDismissedCta()
testee.onUserDismissedCta(cta)
verify(mockDismissedCtaDao, never()).insert(DismissedCta(cta.ctaId))
}

@Test
fun whenUserDismissedSurveyCtaThenCancelScheduledSurveys() {
val cta = HomePanelCta.Survey(Survey("abc", "http://example.com", daysInstalled = 1, status = Survey.Status.SCHEDULED))
testee.ctaViewState.value = BrowserTabViewModel.CtaViewState(cta = cta)

testee.onUserDismissedCta()
testee.onUserDismissedCta(cta)
verify(mockSurveyDao).cancelScheduledSurveys()
}

@Test
fun whenUserFailedSettingDdgAsDefaultBrowserFromSettingsThenFirePixelAndUpdateInstallStore() {
whenever(mockDefaultBrowserDetector.isDefaultBrowser()).thenReturn(false)

testee.onUserTriedToSetAsDefaultBrowserFromSettings()

verify(mockAppInstallStore).defaultBrowser = false
verify(mockPixel).fire(Pixel.PixelName.DEFAULT_BROWSER_NOT_SET, defaultBrowserPixelParams(Pixel.PixelValues.DEFAULT_BROWSER_SETTINGS))
}

@Test
fun whenUserHasSetDdgAsDefaultBrowserFromSettingsThenFirePixelAndUpdateInstallStore() {
whenever(mockDefaultBrowserDetector.isDefaultBrowser()).thenReturn(true)

testee.onUserTriedToSetAsDefaultBrowserFromSettings()

verify(mockAppInstallStore).defaultBrowser = true
verify(mockPixel).fire(Pixel.PixelName.DEFAULT_BROWSER_SET, defaultBrowserPixelParams(Pixel.PixelValues.DEFAULT_BROWSER_SETTINGS))
}

@Test
fun whenUserFailedSettingDdgAsDefaultBrowserFromDialogOnceThenOpenDefaultBrowserDialogAgain() {
whenever(mockDefaultBrowserDetector.isDefaultBrowser()).thenReturn(false)

testee.onUserTriedToSetAsDefaultBrowserFromDialog()

assertCommandIssued<Command.OpenDefaultBrowserDialog>()
}

@Test
fun whenUserFailedSettingDdgAsDefaultBrowserFromDialogTwiceThenFirePixelAndUpdateInstallStore() {
whenever(mockDefaultBrowserDetector.isDefaultBrowser()).thenReturn(false)

testee.onUserTriedToSetAsDefaultBrowserFromDialog()
testee.onUserTriedToSetAsDefaultBrowserFromDialog()

verify(mockAppInstallStore, times(2)).defaultBrowser = false
verify(mockPixel).fire(
Pixel.PixelName.DEFAULT_BROWSER_NOT_SET,
defaultBrowserPixelParams(Pixel.PixelValues.DEFAULT_BROWSER_JUST_ONCE_MAX)
)
}

@Test
fun whenUserHasSetDdgAsDefaultBrowserFromDialogThenFirePixelAndUpdateInstallStore() {
whenever(mockDefaultBrowserDetector.isDefaultBrowser()).thenReturn(true)

testee.onUserTriedToSetAsDefaultBrowserFromDialog()

verify(mockAppInstallStore).defaultBrowser = true
verify(mockPixel).fire(Pixel.PixelName.DEFAULT_BROWSER_SET, defaultBrowserPixelParams(Pixel.PixelValues.DEFAULT_BROWSER_DIALOG))
}

@Test
fun whenUserDismissesDefaultBrowserDialogThenFirePixelAndUpdateInstallStore() {
whenever(mockDefaultBrowserDetector.isDefaultBrowser()).thenReturn(false)

testee.onUserDismissedDefaultBrowserDialog()

verify(mockAppInstallStore).defaultBrowser = false
verify(mockPixel).fire(
Pixel.PixelName.DEFAULT_BROWSER_NOT_SET,
defaultBrowserPixelParams(Pixel.PixelValues.DEFAULT_BROWSER_DIALOG_DISMISSED)
)
}

@Test
fun whenDefaultBrowserDialogDismissedAfterSelectingDefaultExternalBrowserAlwThenFirePixelAndUpdateInstallStore() {
whenever(mockDefaultBrowserDetector.isDefaultBrowser()).thenReturn(false)
whenever(mockDefaultBrowserDetector.hasDefaultBrowser()).thenReturn(true)

testee.onUserDismissedDefaultBrowserDialog()

verify(mockAppInstallStore).defaultBrowser = false
verify(mockPixel).fire(
Pixel.PixelName.DEFAULT_BROWSER_NOT_SET,
defaultBrowserPixelParams(Pixel.PixelValues.DEFAULT_BROWSER_EXTERNAL)
)
}

private inline fun <reified T : Command> assertCommandIssued(instanceAssertions: T.() -> Unit = {}) {
verify(mockCommandObserver, atLeastOnce()).onChanged(commandCaptor.capture())
val issuedCommand = commandCaptor.allValues.find { it is T }
Expand All @@ -1548,6 +1652,12 @@ class BrowserTabViewModelTest {
Pixel.PixelParameter.BOOKMARK_CAPABLE to bookmarkCapable.toString()
)

private fun defaultBrowserPixelParams(origin: String) = mapOf(
Pixel.PixelParameter.DEFAULT_BROWSER_SET_FROM_ONBOARDING to false.toString(),
Pixel.PixelParameter.DEFAULT_BROWSER_SET_ORIGIN to origin
)


private fun givenExpectedCtaAddWidgetInstructions() {
setBrowserShowing(false)
whenever(mockWidgetCapabilities.supportsStandardWidgetAdd).thenReturn(true)
Expand Down
Loading