Skip to content

Conversation

@cmonfortep
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414730916066338/1167347031598071/f
Tech Design URL:
CC:

Description:

  • Enabling se, sc variants
  • Finish LaunchBridgeActivity after being routed to the onboarding.

Steps to test this PR:

SC variant

  1. Hardcode variant "sc"
  2. Fresh install
  3. open the app and navigate to Browser screen
  4. perform a search
  5. Ensure from the logs that duckduckgo url contains "sc" as part of atb

SC variant

  1. Hardcode variant "se"
  2. Fresh install
  3. open the app and navigate to Browser screen
  4. perform a search
  5. Ensure from the logs that duckduckgo url contains "se" as part of tab

Finish

  1. Fresh install
  2. open the app and navigate to Browser
  3. click back and ensure no more activities were alive.

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cmonfortep cmonfortep merged commit b264e84 into develop Mar 19, 2020
@cmonfortep cmonfortep deleted the feature/cristian/enable_se_sc_variants branch March 19, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants