Skip to content

Feature/cristian/enable se sc variants #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Feature/cristian/enable se sc variants #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3f7a25
Enabling search variants
cmonfortep Mar 19, 2020
f9354a8
Finish LaunchBridgeActivity after routing to OnboardingActivity
cmonfortep Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ class VariantManagerTest {
@Test
fun serpControlVariantIsInactiveAndHasNoFeatures() {
val variant = variants.first { it.key == "sc" }
assertEqualsDouble(0.0, variant.weight)
assertEqualsDouble(1.0, variant.weight)
assertEquals(0, variant.features.size)
}

@Test
fun serpExperimentalVariantIsInactiveAndHasNoFeatures() {
val variant = variants.first { it.key == "se" }
assertEqualsDouble(0.0, variant.weight)
assertEqualsDouble(1.0, variant.weight)
assertEquals(0, variant.features.size)
}

Expand Down
1 change: 1 addition & 0 deletions app/src/main/java/com/duckduckgo/app/launch/LaunchBridgeActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ class LaunchBridgeActivity : DuckDuckGoActivity() {
} else {
startActivity(OnboardingActivity.intent(this))
}
finish()
}

private fun showHome() {
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ interface VariantManager {
val ACTIVE_VARIANTS = listOf(
// SERP variants. "sc" may also be used as a shared control for mobile experiments in
// the future if we can filter by app version
Variant(key = "sc", weight = 0.0, features = emptyList(), filterBy = { noFilter() }),
Variant(key = "se", weight = 0.0, features = emptyList(), filterBy = { noFilter() }),
Variant(key = "sc", weight = 1.0, features = emptyList(), filterBy = { noFilter() }),
Variant(key = "se", weight = 1.0, features = emptyList(), filterBy = { noFilter() }),

// Concept test experiment
Variant(key = "mc", weight = 0.0, features = emptyList(), filterBy = { isEnglishLocale() }),
Expand Down