Add user toggle to control tracker animation #7492
Merged
+402
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibrahim-
force-pushed
the
feature/aibrahim/toggle_tracker_count_animation
branch
from
78eb66c to
4901fcd
Compare
mikescamell
reviewed
Jan 15, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
Outdated
Show resolved
Hide resolved
mikescamell
reviewed
Jan 15, 2026
app/src/main/java/com/duckduckgo/app/appearance/AppearanceViewModel.kt
Outdated
Show resolved
Hide resolved
aibrahim-
force-pushed
the
feature/aibrahim/toggle_tracker_count_animation
branch
2 times, most recently
from
379ed62 to
06384f5
Compare
aibrahim-
force-pushed
the
feature/aibrahim/toggle_tracker_count_animation
branch
7 times, most recently
from
d94a071 to
33bdf88
Compare
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1212857118626392 |
aibrahim-
force-pushed
the
feature/aibrahim/toggle_tracker_count_animation
branch
2 times, most recently
from
4f3344c to
88222b3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
aibrahim-
force-pushed
the
feature/aibrahim/toggle_tracker_count_animation
branch
2 times, most recently
from
44c3964 to
dd0ed19
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
aibrahim-
force-pushed
the
feature/aibrahim/toggle_tracker_count_animation
branch
from
dd0ed19 to
d2a656b
Compare
aibrahim-
force-pushed
the
feature/aibrahim/toggle_tracker_count_animation
branch
from
d2a656b to
84e29f6
Compare
Contributor
|
I think we should remove |
mikescamell
reviewed
Jan 23, 2026
app/src/main/java/com/duckduckgo/app/appearance/AppearanceViewModel.kt
Outdated
Show resolved
Hide resolved
mikescamell
reviewed
Jan 23, 2026
aibrahim-
force-pushed
the
feature/aibrahim/toggle_tracker_count_animation
branch
from
84e29f6 to
7e93e73
Compare
Translations for: #7492 Task/Issue URL: https://app.asana.com/1/137249556945/project/1212608036467427/task/1212746115452340 ### Description ### Steps to test this PR _Feature 1_ - [ ] - [ ] ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)| <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds localized strings for the tracker-blocked count animation and related settings across many locales, and updates EN resources accordingly. > > - Introduces `trackerBlockedInTheLast7days` plus labels for the feature (`settingsTrackersBlockedAnimationHeaderTitle`, `showTrackerCountInAddressBar`, `showWeeklyTrackerCountInTabSwitcher`) in `values-*.xml` > - Removes these keys from `values/donottranslate.xml` and adds them to `values/strings.xml` (EN), replacing the old `showTrackerCountInTabSwitcher` > - Minor copy/format adjustments per locale (bold tags, placeholders) > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit a36f05b. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Dax The Translator <daxmobile@duckduckgo.com>
mikescamell
approved these changes
Jan 27, 2026
Contributor
mikescamell
left a comment
mikescamell
left a comment
There was a problem hiding this comment.
LGTM 🚢 🇮🇹
Feel free to merge after tests pass 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1212608036467427/task/1212695169153020?focus=true
Description
Create a user controlled settings toggle to disable tracker animation in address bar.
Steps to test this PR
UI changes
recording.mp4
Note
Introduces a user-controlled setting to enable/disable the address bar trackers animation and reorganizes related Appearance settings.
showTrackersCountInAddressBarpreference inSettingsDataStore(default true) with UI toggle inactivity_appearance.xmlunder a new "Trackers Blocked Animation" section; strings and translations addedAppearanceViewModel: exposesisAddressBarTrackersAnimationEnabledandshouldShowAddressBarTrackersAnimationItem(gated byAddressBarTrackersAnimationManager.isFeatureEnabled()), persists changes, and fires pixelm_appearance_settings_is_tracker_count_in_address_bar_toggledBrowserTabViewModel: respects the new setting inisTrackersAnimationEnabled;OmnibarLayoutViewModeluses view state flag forisAddressBarTrackersAnimationEnabledPixelParamRemovalInterceptorupdated to strip params for the new pixel; pixel definition added inPixelDefinitions/pixels/appearance_settings.json5Written by Cursor Bugbot for commit 9810d76. This will update automatically on new commits. Configure here.