Send pixel events for the RMF remote image load success/ failure#7496
Merged
catalinradoiu merged 35 commits intodevelopfrom Jan 19, 2026
Merged
Send pixel events for the RMF remote image load success/ failure#7496catalinradoiu merged 35 commits intodevelopfrom
catalinradoiu merged 35 commits intodevelopfrom
Conversation
…r top illustration configuration in the message cta
…r Json remote message mapper
# Conflicts: # android-design-system/design-system/src/main/res/layout/view_remote_message_cta.xml
# Conflicts: # remote-messaging/remote-messaging-impl/src/main/java/com/duckduckgo/remote/messaging/impl/modal/cardslist/CardsListRemoteMessageView.kt
…age is dismissed instead of using the cache
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
catalinradoiu
changed the base branch from
feature/cradoiu/rmf-image-load
to
develop
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1212839372467455 |
…-rmf-image-load # Conflicts: # android-design-system/design-system/src/main/java/com/duckduckgo/common/ui/view/MessageCta.kt # remote-messaging/remote-messaging-impl/src/main/java/com/duckduckgo/remote/messaging/impl/modal/cardslist/CardsListRemoteMessageView.kt # remote-messaging/remote-messaging-impl/src/test/java/com/duckduckgo/remote/messaging/newtab/RemoteMessageViewModelTest.kt
cmonfortep
approved these changes
Jan 16, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
catalinradoiu
deleted the
feature/cradoiu/add-pixels-for-rmf-image-load
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1212774577583911?focus=true
Description
Added tracking for remote message image loading success and failure events. This PR implements two new pixels:
m_remote_message_image_load_success: Fired when a remote message image loads successfullym_remote_message_image_load_failed: Fired when a remote message image fails to loadThe implementation adds callbacks in the
MessageCtacomponent to detect image loading states and fires the appropriate pixels in the various view models that use remote messaging.Steps to test this PR
Image loading success
m_remote_message_image_load_successpixel is fired when the image loads successfullyImage loading failure
m_remote_message_image_load_failedpixel is fired when the image fails to loadUI changes
Note
Adds telemetry for remote message image loading across RMF surfaces.
m_remote_message_image_load_successandm_remote_message_image_load_failedinremote_messaging_framework.json5and exposes them viaRemoteMessagingPixelNameRequestListenerimage callbacks inMessageCta,RemoteMessageView, andCardsListRemoteMessageViewto notify VMsmessageid) fromRemoteMessageViewModel,NewTabLegacyPageViewModel, andCardsListRemoteMessageViewModelPixelParamRemovalInterceptorto stripatbfor the new pixelsWritten by Cursor Bugbot for commit 5a3ecce. This will update automatically on new commits. Configure here.