Add UI Components and feature flag for duck.ai recent chats by YoussefKeyrouz · Pull Request #7685 · duckduckgo/Android

YoussefKeyrouz · 2026-02-05T18:04:55Z

Task/Issue URL: https://app.asana.com/1/137249556945/task/1213130409431278

Description

First part of the recent chats feature, which implements a chat suggestion list in the duck.ai tab of the input screen.

Introduces a new feature flag: aiChatSuggestions. When enabled, the AI chat suggestions (pinned and recent chats) in the input screen's duck.ai mode.

The UI is currently a work in progress and is using static test data.

Changes:

Added a new overlay in the input screen fragment for the chat suggestions. This follows the same pattern as the autocomplete overlay.
Add a recycler view (with its adapter and items) to the chatSuggestionsOverlay to display the list of recent chats.
Modified how the Logo visibility is handled. The Duck.ai chat logo should no longer be visible even if there are not recent chat items. Only the search logo will be visible (Follows iOS implementation)
Added icons for the chats (pin vs chat bubble)
Added the model for the Chat suggestion. It follow the expected structure for future integration with the JS frontend.
Modified the Input Screen View Model to load the static list.
All the changes are UX/fragments, Testing will be done through Maestro. Unit tests will be implemented when real data starts flowing through the view model.

Next Steps

Connect with the real frontend data once the JS webview interface is ready
Clicking on a recent chat should navigate you to the Duck.ai page and load the related chat.
Maestro tests

Steps to test this PR

Notes: in order to facilitate testing, I created an additional branch with static data. Please pull the origin/feature/youssef/do_not_merge/recent_ai_chats_ui_test_data branch to test this PR with data and see the behavior. This would prevent having test data part of the merge and allow PR testing.

Pull the changes and run the app
Go to feature flags settings and turn on "aiChatSuggestions" flag (it's off by default)
Go back to the input screen, make sure the omnibar is enabled
Switch to the "Duck.ai" tab. You should see a static list of chats, both pinned and recent.
Switch back and forth between search and chat to make sure the interaction and visibility is correct. You can test different behaviors on the search tab such as searching or adding a favorite. No impact should be observed.
If "aiChatSuggestions" is disabled, the app should behave as it is currently in production. No impact should be observed

UI changes

Before	After

Note

Medium Risk
Feature-flagged but touches core input-screen UI state/animation and overlay interaction, which can introduce subtle regressions in tab switching, visibility, and touch handling.

Overview
Adds a new remote sub-feature flag, DuckChatFeature.aiChatSuggestions, to gate an in-progress “recent/pinned chats” suggestions experience in the Duck.ai input-screen tab.

When enabled, the input screen now includes a new chatSuggestionsOverlay (RecyclerView + bottom fade/blur) and shared overlay animation logic, and updates logo/overlay/viewpager-interaction behavior to avoid showing the Duck.ai logo and to ensure autocomplete/suggestions overlays don’t overlap during mode switches. ChatTabFragment is expanded to wire up a ChatSuggestionsAdapter and observe a new InputScreenViewModel.chatSuggestions flow (loading stubbed via a TODO), with new pin/chat icons and an item_chat_suggestion row layout; tests are updated to inject the new feature toggle dependency.

^{Written by Cursor Bugbot for commit 595d297. This will update automatically on new commits. Configure here.}

YoussefKeyrouz · 2026-02-05T18:05:21Z

Add UI Components and feature flag for duck.ai recent chats #7685 👈 (View in Graphite)
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

...ckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenFragment.kt

duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/feature/DuckChatFeature.kt

.../src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/viewmodel/InputScreenViewModel.kt

joshliebe · 2026-02-06T13:17:31Z

...impl/src/test/kotlin/com/duckduckgo/duckchat/impl/ui/inputscreen/InputScreenViewModelTest.kt

+
+    // Chat Suggestions Tests
+
+    @SuppressLint("DenyListedApi")


nit: Can just suppress once at the top of the class

I usually like to keep it scoped per test so if someone add a new test that causes the same linting warning, they would be aware of it and specifically indicate they are ok suppressing it. But if you prefer top of the file I can do that. let me know

joshliebe · 2026-02-06T13:17:41Z

...impl/src/test/kotlin/com/duckduckgo/duckchat/impl/ui/inputscreen/InputScreenViewModelTest.kt

+                assertTrue(initialState.showChatLogo)
+
+                viewModel.onChatSelected()
+                advanceUntilIdle()


You can remove the advanceUntilIdle() in these tests, it’s not needed

joshliebe · 2026-02-06T13:33:28Z

duckchat/duckchat-impl/src/main/res/layout/fragment_chat_tab.xml

+        app:layout_constraintTop_toTopOf="parent"
+        tools:visibility="visible" />
+
+    <androidx.recyclerview.widget.RecyclerView


As mentioned, this causes sliding of the list. The behavior should be the same as the new tab page/autocomplete list.

The list also needs the bottom blur

Yeah this whole component will be made to match the autocomplete list

joshliebe · 2026-02-06T14:01:26Z

duckchat/duckchat-impl/src/main/res/layout/fragment_chat_tab.xml

-    android:layout_height="match_parent" />
+    android:layout_height="match_parent" >
+
+    <com.duckduckgo.common.ui.view.text.DaxTextView


Compared to Figma, the header needs some bottom padding

The header is also static, it needs to scroll with the list

The padding/margin is on my list of things to address. Haven’t properly match them yet. For the header I will address it too but just curious how did you know it needs to scroll?

Checked with @Bunn and there’s no header anymore, you can delete it.

joshliebe

Nothing blocking but added some comments

cursor

Cursor Bugbot has reviewed your changes and found 3 potential issues.

...ckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenFragment.kt

...kchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/tabs/ChatTabFragment.kt

joshliebe

Code changes look good and it works great, LGTM 🚀

Task/Issue URL: https://app.asana.com/1/137249556945/task/1213218251714196 ### Description With the addition of the recent chat overlay ([PR](#7685)), the Duck.ai logo should be hidden when chat suggestions are available and visible when they are not. The implementation simplifies the code by removing multiple boolean checks and accommodates for all different transition use cases and interactions with the DuckDuckGo logo (that shows on the Search tab). When moving from one tab to another: - If both logos are visible —> transition with animation - If one logo is visible while the other hidden by an overlay or favourites —> logo fades in/out - Both tap and swipe gestures follow same behaviour. Swiping animates progression. - Dismissing the overlay on the current tab shows the correct logo depending on which tab you are in ### Additional notes - Addressed the use cases where changing text on one tab, should reflect properly on the other tab when going back (logo animations should accommodate for what both tabs are showing) - Fixed an existing bug when we access the input screen from a website (click on the address bar while visiting a website). The search box is not empty but the autocomplete overlay is hidden, this breaks the logo swipe animation due to it relying on the box being empty to do transitions. ### Steps to test this PR Note: in order to facilitate testing, I created an additional branch with static data. Feel free to pull the `feature/youssef/do_not_merge/test_input_screen_logo_transition` branch to test with suggestions. - Pull the changes - Go to the input screen, make sure the omnibar is enabled - Switch between search tab and duck.ai tab with no overlays (both logos visible) - Write a search query for the auto complete to show up and switch between tabs to see fade in/out animations - Add favourite and switch between tabs - Write a search query in the search tab, toggle the duck.ai tab, delete the text from the chat box, swipe back to the search tab —> animation should play because autocomplete is now hidden. - Go to a website (example.com) tap on the address bar to show the input screen. Swipe between the tabs. Logo should animate properly (existing bug fixed) - Test with feature flag OFF —> No changes or regression from current production behaviour ### UI changes Demo for the full feature: https://github.com/user-attachments/assets/96abf963-59f5-4b2e-8742-753d957e1142  --- > [!NOTE] > **Medium Risk** > Touches core UI state and animation logic for the input screen; regressions would primarily be visual/interaction-related (logo/overlay transitions) rather than data or security, but the behavior matrix is broad. > > **Overview** > Updates input-screen logo behavior so the Duck.ai logo hides when chat suggestions are present and logo transitions only *morph* when both the search and chat logos are visible; otherwise mode changes use simple fade in/out based on per-mode logo visibility. > > Simplifies gesture handling by removing swipe-start state flags and relying on `showSearchLogo`/`showChatLogo` in `onPageScrolled`/`onTabTapped`, adds `chatSuggestionsVisible` to `InputScreenVisibilityState`, and proactively clears stale search text when chat input is emptied to keep logo state/animations consistent (including the “opened from URL” case). Tests are updated to match the new command-emission rules. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 84ee39d. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>  Co-authored-by: Youssef Keyrouz <ykeyrouz@Youssefs-MacBook-Pro.local>

YoussefKeyrouz force-pushed the feature/youssef/recent_ai_chats_ui branch from dbeb1b8 to 754abb3 Compare February 5, 2026 18:36

YoussefKeyrouz requested a review from joshliebe February 5, 2026 19:06

YoussefKeyrouz marked this pull request as ready for review February 5, 2026 23:26

cursor bot reviewed Feb 5, 2026

View reviewed changes

...ckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenFragment.kt Outdated Show resolved Hide resolved

joshliebe self-assigned this Feb 6, 2026

joshliebe reviewed Feb 6, 2026

View reviewed changes

duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/feature/DuckChatFeature.kt Show resolved Hide resolved

joshliebe reviewed Feb 6, 2026

View reviewed changes

.../src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/viewmodel/InputScreenViewModel.kt Outdated Show resolved Hide resolved

joshliebe reviewed Feb 6, 2026

View reviewed changes

joshliebe approved these changes Feb 6, 2026

View reviewed changes

YoussefKeyrouz force-pushed the feature/youssef/recent_ai_chats_ui branch 2 times, most recently from 3825105 to 2fb5325 Compare February 9, 2026 07:22

cursor bot reviewed Feb 9, 2026

View reviewed changes

Add UI components for the recent AI chats list

595d297

YoussefKeyrouz force-pushed the feature/youssef/recent_ai_chats_ui branch from 2fb5325 to 595d297 Compare February 9, 2026 08:15

YoussefKeyrouz requested a review from joshliebe February 9, 2026 08:22

joshliebe assigned joshliebe and unassigned joshliebe Feb 9, 2026

joshliebe approved these changes Feb 9, 2026

View reviewed changes

YoussefKeyrouz merged commit 79e69b4 into develop Feb 9, 2026
24 checks passed

YoussefKeyrouz deleted the feature/youssef/recent_ai_chats_ui branch February 9, 2026 22:10

YoussefKeyrouz mentioned this pull request Feb 11, 2026

Logo behaviour in input screen #7723

Merged

Conversation

YoussefKeyrouz commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps to test this PR

UI changes

Uh oh!

YoussefKeyrouz commented Feb 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joshliebe left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joshliebe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

YoussefKeyrouz commented Feb 5, 2026 •

edited

Loading