Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
21 tasks
CDRussell
force-pushed
the
feature/craig/autofill_async_sqlcipher_error_pixels
branch
from
67f4bfb to
81175f2
Compare
CDRussell
commented
Feb 6, 2026
| AUTOFILL_HARMONY_PREFERENCES_GET_KEY_FAILED("autofill_harmony_preferences_get_key_failed"), | ||
| AUTOFILL_PREFERENCES_UPDATE_KEY_FAILED("autofill_preferences_update_key_failed"), | ||
| AUTOFILL_HARMONY_PREFERENCES_UPDATE_KEY_FAILED("autofill_harmony_preferences_update_key_failed"), | ||
| LIBRARY_LOAD_TIMEOUT_SQLCIPHER("library_load_timeout_sqlcipher"), |
Member
Author
There was a problem hiding this comment.
in autofill for now but will likely move the sqlcipher library elsewhere for general use after it's been out for a bit
CDRussell
force-pushed
the
feature/craig/autofill_async_sqlcipher_error_pixels
branch
from
81175f2 to
60314cd
Compare
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1213151886912519 |
CrisBarreiro
approved these changes
Feb 13, 2026
Member
Author
Merge activity
|
CDRussell
changed the base branch from
feature/craig/autofill-use-async-sqlcipher-loader
to
graphite-base/7694
CDRussell
force-pushed
the
feature/craig/autofill_async_sqlcipher_error_pixels
branch
from
60314cd to
964c2af
Compare
CDRussell
deleted the
feature/craig/autofill_async_sqlcipher_error_pixels
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/task/1213116557045964
Description
Adds error pixels if there's a problem with the new async
sqlciphernative library loading.Logcat filter: message~:
"SqlCipher-Init: |Autofill-DB-Init: |library_load_"Patches for testing the various error cases: Testing patches
Steps to test this PR
#### Timeouts
Pixel sent: library_load_timeout_sqlcipherin logs#### Timeouts
Pixel sent: library_load_failure_sqlcipherin logsNote
Low Risk
Adds telemetry-only behavior gated to async loading; no changes to the actual library loading flow beyond emitting pixels and updating tests.
Overview
Adds two new daily error pixels (
library_load_timeout_sqlcipher,library_load_failure_sqlcipher) to track sqlcipher native library async loading issues, including wiring them intoAutofillPixelNamesand data-cleaning rules.Updates
SqlCipherLibraryLoader.waitForLibraryLoadto fire the appropriate pixel on timeout or exception only when async loading is enabled, and extends unit tests to verify pixels fire (or not) across timeout, failure, success, and sync-loading scenarios.Written by Cursor Bugbot for commit 60314cd. Configure here.