Skip to content

PIR: Add vpn_connection_state to eligible pixels#7704

Merged
karlenDimla merged 1 commit intodevelopfrom
feature/karl/pixel/vpn_connection_state
Feb 10, 2026
Merged

PIR: Add vpn_connection_state to eligible pixels#7704
karlenDimla merged 1 commit intodevelopfrom
feature/karl/pixel/vpn_connection_state

Conversation

@karlenDimla
Copy link
Contributor

@karlenDimla karlenDimla commented Feb 9, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/task/1213085863198314

Description

See attached task description

Steps to test this PR

https://app.asana.com/1/137249556945/task/1213176315984932


Note

Medium Risk
Touches analytics/pixel APIs and their call sites, requiring signature updates across production and tests; runtime risk is mitigated by wrapping VPN state lookup in runCatching and defaulting to false.

Overview
PIR now enriches eligible scan/opt-out result pixels with a new vpn_connection_state parameter (mapped to connected/disconnected) for PIR_SCAN_STAGE_RESULT_* and opt-out submit success/failure pixels.

RealPirRunStateHandler is updated to depend on NetworkProtectionState and safely query isRunning() (fail-closed) when emitting these pixels; tests and the end-to-end instrumentation setup add a FakeNetworkProtectionState, and pir-impl now depends on :network-protection-api.

Written by Cursor Bugbot for commit 754362f. This will update automatically on new commits. Configure here.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@karlenDimla karlenDimla requested a review from landomen February 9, 2026 14:20
@karlenDimla karlenDimla assigned landomen and unassigned landomen Feb 9, 2026
@karlenDimla karlenDimla merged commit 0c04da4 into develop Feb 10, 2026
15 of 20 checks passed
@karlenDimla karlenDimla deleted the feature/karl/pixel/vpn_connection_state branch February 10, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants