Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...ptions-impl/src/main/java/com/duckduckgo/subscriptions/impl/settings/views/PirSettingView.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/task/1212922585263994
Description
See attached task description
Steps to test this PR
https://app.asana.com/1/137249556945/task/1213230593027484
Note
Low Risk
Adds a new
isBetafield to an existing JS messaging response and a small UI label; main risk is backwards-compatibility for any consumers expecting the oldGetFeatureConfigResponseshape.Overview
Adds a beta indicator for PIR in both the web dashboard config and the Android settings UI.
The
GET_FEATURE_CONFIGJS message response now includes a newisBetaboolean (currently alwaystrue), with tests updated to assert the new field. The PIR settings row also gets a "Beta" pill (pillText) and only shows the pill when PIR is in the dashboard-enabled state.Written by Cursor Bugbot for commit 5c56e2a. This will update automatically on new commits. Configure here.