Fix issue where context is not attach on first use#7790
Conversation
app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
Outdated
Show resolved
Hide resolved
|
@aitorvs I’ve made a few changes, mostly consolidating when the page context is collected to make sure it’s always there. Take a look and we can discuss. |
app/src/test/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:6:27: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:3:32: Double quote to prevent globbing and word splitting [shellcheck]
| runs-on: macos-latest | ||
|
|
||
| steps: | ||
| - name: Check app-version value |
There was a problem hiding this comment.
PLACEHOLDER validation removed but default value remains
Low Severity
The PLACEHOLDER input validation check was removed from release_create_task.yml, but the workflow_dispatch input still has default: 'PLACEHOLDER' on line 15. While the orchestrator workflow runs release_create_tag.yml first (which now has the check), release_create_task.yml can still be triggered independently via manual dispatch. A manual trigger without changing the default would create an Asana task named "Android Release PLACEHOLDER".
Please tell me if this was useful or not with a 👍 or 👎.
137b396 to
94d9280
Compare



Task/Issue URL: https://app.asana.com/1/137249556945/project/1211654189969294/task/1213386554167128?focus=true
Description
On first time use the page content is not attached.
Repro steps:
Steps to test this PR
The following repro steps should now work
Repro steps:
Note
Low Risk
Small, localized change to when a JS subscription event is emitted; main risk is timing/regression in contextual sheet analytics or page-context attachment triggering.
Overview
Fixes first-run Duck.ai contextual mode not attaching page content by triggering page-context collection when the contextual bottom sheet is shown.
Moves the page-context subscription event send out of the omnibar click path into a new
BrowserTabViewModel.collectPageContext()called fromBrowserTabFragment.showDuckChatContextualSheet, and adds unit tests to verify the event is emitted only when explicitly collecting context (and not during onboarding).Written by Cursor Bugbot for commit 7f779d0. This will update automatically on new commits. Configure here.