Conversation
catalinradoiu
approved these changes
Feb 23, 2026
Contributor
|
LGTM! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1201462886803403/task/1213397161359075?focus=true
Description
Added support for two new remote message placeholders:
BOOKMARKS_IMPORTandNEW_TAB_OPTIONS. This includes:bookmarks_import_96.xmlandnewtab_options_96.xmlto the design systemBOOKMARKS_IMPORTandNEW_TAB_OPTIONSenum values to thePlaceholderclassSteps to test this PR
Code review only.
NO UI changes
Note
Low Risk
Adds new drawable assets and extends placeholder-to-drawable mappings; risk is limited to incorrect resource wiring or unexpected placeholder values causing UI fallback/crashes.
Overview
Adds support for two new remote message placeholders,
BOOKMARKS_IMPORTandNEW_TAB_OPTIONS, including new 96dp vector illustration resources (bookmarks_import_96.xml,newtab_options_96.xml).Extends the remote messaging API
Placeholderenum and updates both app and remote-messaging-impl mappers to resolve these placeholders to the new drawables when rendering remote message cards.Written by Cursor Bugbot for commit cad12ce. This will update automatically on new commits. Configure here.