Add global RxJava error handler to look for UndeliverableExceptions #787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1172307373191458
Tech Design URL:
CC:
Description:
After updating the app dependencies to newest versions of all libraries, we noticed an increase in UndeliverablExceptions. This, it seems, is most likely caused by our sync job being interrupted, so we in turn dispose of the RxJava subscription. However in cases where the networking capabilities have just dropped (a potential cause of the sync job being stopped) we would then get a bunch of IO-related exceptions being called and since we'd already disposed, RxJava would have nowhere to deliver the exception to, hence it would throw an UndeliverableException.
This UndeliverableException wouldn't be caught by a custom RxJava global error handler (as we don't set one) so it would default to the uncaught exception handler for the thread, which would crash the app.
This change catches and logs UndeliverableExceptions but doesn't let the app crash because of them. For all other exceptions, they continue to defer to the uncaught exception handler as before.
Steps to test this PR:
Getting the sync job to fail at the right time is hard, so best to replicate this scenario is to start the sync and then almost immediately dispose of that RxJava subscription. ie, stick this somewhere you can invoke it at your pleasure 👇
ℹ️This might not crash every time, but it should do most of the time it is run.
developInternal references:
Software Engineering Expectations
Technical Design Template