Skip to content

Conversation

@CDRussell
Copy link
Member

@CDRussell CDRussell commented Apr 22, 2020

Task/Issue URL: https://app.asana.com/0/488551667048375/1172356004360461
Tech Design URL:
CC:

Description:
Adds InterruptedIOException and InterruptedException to the list that we don't want to crash the app on. These exceptions were observed to be happening in the 5.22.3 release. These are essentially the ones signalling that there was an internet issue or that the sync job was instructed to stop mid way through; they aren't real exceptions that should cause the app to stop.

Steps to test this PR:

  1. Similar to Add global RxJava error handler to look for UndeliverableExceptions #787, it's hard to replicate. But I found I could replicate by making the TrackerDataDownloader do lots of extra work, and killing the wifi off while it's looping. e.g., 👇
for (i in 0..100) {
    Timber.i("Running TDS download #$i")
    val call = trackerListService.tds()
    val response = call.execute()
}

Internal references:

Software Engineering Expectations
Technical Design Template

@cmonfortep cmonfortep self-assigned this Apr 23, 2020
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CDRussell CDRussell merged commit 273b00d into develop Apr 23, 2020
@CDRussell CDRussell deleted the feature/craig/ignore_interrupted_exceptions branch April 23, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants