PIR: Add additional pixels and params for download errors

[karlenDimla]

Task/Issue URL: https://app.asana.com/1/137249556945/task/1213531646709003?focus=true

Description

Add additional params to download errors
Separate pixel for main config and json errors

Steps to test this PR

https://app.asana.com/1/137249556945/task/1213552181080627?focus=true

---

Note

Medium Risk
Medium risk because it changes PirPixelSender method signatures (now suspend) and wiring/DI to always derive VPN state from NetworkProtectionState, which can break call sites or affect pixel emission timing if any integration is missed.

Overview
Adds more granular PIR download error telemetry by introducing a dedicated m_dbp_download_broker-json_failure pixel and by attaching vpn_connection_state to main-config download failure pixels.

Updates the PIR pixel-sending pipeline so VPN state is computed inside RealPirPixelSender (via injected NetworkProtectionState) rather than being passed through, and adjusts download/update flows (BrokerJsonUpdater) to emit the new broker-json failure pixel when broker JSON downloads fail without advancing etags.

Tests and integration setup are updated to match the new constructor dependencies and the suspend pixel-reporting APIs.

^{Written by Cursor Bugbot for commit c94b9be. This will update automatically on new commits. Configure here.}

[karlenDimla]

• PIR: Add additional pixels and params for download errors #7894 👈 (View in Graphite)
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Privacy Review task: https://app.asana.com/0/69071770703008/1213521097314010

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Inner runCatching swallows CancellationException from suspend function
  • Added explicit check to rethrow CancellationException in the onFailure block before other error handling, ensuring proper coroutine cancellation propagation.

Or push these changes by commenting:

@cursor push 95a8946f0d

Preview (95a8946f0d)

diff --git a/pir/pir-impl/src/main/java/com/duckduckgo/pir/impl/brokers/BrokerJsonUpdater.kt b/pir/pir-impl/src/main/java/com/duckduckgo/pir/impl/brokers/BrokerJsonUpdater.kt
--- a/pir/pir-impl/src/main/java/com/duckduckgo/pir/impl/brokers/BrokerJsonUpdater.kt
+++ b/pir/pir-impl/src/main/java/com/duckduckgo/pir/impl/brokers/BrokerJsonUpdater.kt
@@ -24,6 +24,7 @@
 import com.duckduckgo.pir.impl.store.PirRepository
 import com.duckduckgo.pir.impl.store.PirRepository.BrokerJson
 import com.squareup.anvil.annotations.ContributesBinding
+import kotlinx.coroutines.CancellationException
 import kotlinx.coroutines.withContext
 import logcat.LogPriority.ERROR
 import logcat.asLog
@@ -77,6 +78,7 @@
                                 pirRepository.updateMainEtag(config.etag)
                             }
                             .onFailure { e ->
+                                if (e is CancellationException) throw e
                                 logcat(ERROR) { "PIR-update: Failed to download broker json files: $e" }
                                 val message = e.asLog().sanitize() ?: e.message ?: "Unknown error"
                                 pixelSender.reportDownloadBrokerJsonFailure(message)

[landomen]

Works as expected