Show subscription dialog when users skip onboarding

[nalcalag]

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1210557489696946?focus=true

Description

Show subscription dialog 7 days after install if onboarding is skipped

Steps to test this PR

Pre steps

• Apply patch on https://app.asana.com/1/137249556945/project/1209991789468715/task/1210448620621729?focus=true

Subscription dialog for users that skip onboarding

• Fresh install
• Skip onboarding as a returning user (Skip onboarding as a returning user (I've been here before > Start Browsing)
• Close the app
• Change the date in your device for >=7 days after today
• Open the app and check subscription onboarding dialog appear (probably subscribe copy as you already used a Free Trial in the past)

Free Trial copy

• On Play Billing Lab app go to Configuration settings and check 'Test free trial or introductory offer'
• Remember to change date back to today
• Fresh install
• Skip onboarding as a returning user (not with dev button)
• Close the app
• Change the date in your device for >=7 days after today
• Open the app and check subscription onboarding dialog appear with Free Trial copy

FF disabled

• Fresh install
• Remember to change date back to today
• Skip onboarding as a returning user (not with dev button)
• Go to Settings > Feature Flag Inventory
• Disable privacyProCtaSkippedOnboarding
• Close the app
• Change the date in your device for >=7 days after today
• Open the app and check subscription onboarding dialog doesn't appear

UI changes

Before	After
!(Upload before screenshot)	(Upload after screenshot)

---

Note

Medium Risk
Changes onboarding CTA selection and command emission timing, which can affect when promos/omnibar input auto-launch and subscription URLs are triggered. Risk is moderate due to new time-based gating, new feature flags, and updated pixel parameters, but it’s isolated to onboarding/promo flows.

Overview
Adds a new Privacy Pro onboarding promo path for returning users who previously skipped onboarding: after 7 days since install, a DaxPrivacyProCta can be returned from CtaViewModel.refreshCta when privacyProCtaSkippedOnboarding is enabled.

Updates the Privacy Pro CTA model to derive title/CTA copy from onboardingSkipped and free-trial eligibility, avoid auto-marking the CTA as read on show, and include new pixel params (ru, free_trial) for shown/OK events. Privacy Pro launch now builds the origin query parameter dynamically via getPrivacyProOnboardingOrigin().

Prevents Duck.ai’s LaunchInputScreen auto-open on new empty tabs when the skipped-onboarding promo is eligible to be shown, reducing UI conflicts. Feature toggle defaults are adjusted (extendedOnboarding.self and privacyProCta default to true; new privacyProCtaSkippedOnboarding added), and tests are updated/added to cover the new gating and suppression behavior.

^{Written by Cursor Bugbot for commit 9d4e7cf. This will update automatically on new commits. Configure here.}

[nalcalag]

• Avoid input screen when promo onboarding dialog shown #7930
• Show subscription dialog when users skip onboarding #7929 👈 (View in Graphite)
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Autofix Details

Bugbot Autofix prepared a fix for 1 of the 2 issues found in the latest run.

• ✅ Fixed: Test doesn't validate the seven-day install check
  • Enabled the privacyProCtaSkippedOnboarding toggle in the less-than-seven-days test so it now exercises the day-threshold path instead of failing early on a disabled feature flag.

Or push these changes by commenting:

@cursor push 3c965bb09d

Preview (3c965bb09d)

diff --git a/app/src/test/java/com/duckduckgo/app/cta/ui/OnboardingDaxDialogTests.kt b/app/src/test/java/com/duckduckgo/app/cta/ui/OnboardingDaxDialogTests.kt
--- a/app/src/test/java/com/duckduckgo/app/cta/ui/OnboardingDaxDialogTests.kt
+++ b/app/src/test/java/com/duckduckgo/app/cta/ui/OnboardingDaxDialogTests.kt
@@ -284,6 +284,7 @@
         whenever(appInstallStore.installTimestamp).thenReturn(System.currentTimeMillis() - 3 * 24 * 3600 * 1000L)
         whenever(dismissedCtaDao.exists(DAX_INTRO_PRIVACY_PRO)).thenReturn(false)
         whenever(extendedOnboardingFeatureToggles.privacyProCta()).thenReturn(mockEnabledToggle)
+        whenever(extendedOnboardingFeatureToggles.privacyProCtaSkippedOnboarding()).thenReturn(mockEnabledToggle)
         whenever(mockSubscriptions.isEligible()).thenReturn(true)
 
         val result = testee.refreshCta(

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: markAsReadOnShow=false also changes regular onboarding CTA behavior
  • Made DaxPrivacyProCta.markAsReadOnShow conditional (!onboardingSkipped) so regular onboarding still auto-dismisses on show while skipped-onboarding continues requiring explicit dismissal.

Or push these changes by commenting:

@cursor push 82c8655380

Preview (82c8655380)

diff --git a/app/src/main/java/com/duckduckgo/app/cta/ui/Cta.kt b/app/src/main/java/com/duckduckgo/app/cta/ui/Cta.kt
--- a/app/src/main/java/com/duckduckgo/app/cta/ui/Cta.kt
+++ b/app/src/main/java/com/duckduckgo/app/cta/ui/Cta.kt
@@ -824,7 +824,7 @@
         onboardingStore = onboardingStore,
         appInstallStore = appInstallStore,
     ) {
-        override val markAsReadOnShow: Boolean = false
+        override val markAsReadOnShow: Boolean = !onboardingSkipped
 
         private fun subscriptionOnboardingPixelParams(): Map<String, String> = mapOf(
             Pixel.PixelParameter.CTA_SHOWN to ctaPixelParam,

[nalcalag]

This was already reviewed by @joshliebe in a stacked PR. There was a conflict between the onboarding dialog and the duck.ai toggle that was fixed there.

[lmac012]

LGTM