test of skipping ci.yml jobs by LukasPaczos · Pull Request #7962 · duckduckgo/Android

LukasPaczos · 2026-03-13T11:13:42Z

Note

Medium Risk
Medium risk because it changes a production aiChat subscription event identifier (could break downstream analytics/behavior) and tweaks CI tooling version, while also adding an accidental-looking README edit.

Overview
Pins the nightly build benchmark workflow to install gradleprofiler 0.23.0 via SDKMAN instead of the latest.

Changes the aiChat stop-tap subscription event name in BrowserTabFragment from submitPromptInterruption to submitPromptInterruptionxx, which will alter downstream event handling/metrics.

Adds a stray asdasd line to build-benchmarks/README.md (likely unintended documentation noise).

^{Written by Cursor Bugbot for commit d6a28a1. This will update automatically on new commits. Configure here.}

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

✅ Fixed: Accidentally committed debug text in README
- Removed the stray asdasd line from build-benchmarks/README.md and restored the intended blank spacing in the examples section.

Or push these changes by commenting:

@cursor push 1ac8013997

Preview (1ac8013997)

diff --git a/build-benchmarks/README.md b/build-benchmarks/README.md
--- a/build-benchmarks/README.md
+++ b/build-benchmarks/README.md
@@ -46,7 +46,6 @@
 
 If your Gradle installation is not in `~/.gradle`, provided that as a parameter as well, see `--gradle-user-home PATH` above.
 
-asdasd
 **Run full benchmark locally:**
 ```bash
 python3 build-benchmarks/run-benchmark.py

build-benchmarks/README.md

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

✅ Fixed: Accidentally committed empty test method in Activity
- The empty no-op test() method was removed from InputScreenActivity to eliminate unintended dead production code.

Or push these changes by commenting:

@cursor push f8931571f5

Preview (f8931571f5)

diff --git a/duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenActivity.kt b/duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenActivity.kt
--- a/duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenActivity.kt
+++ b/duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenActivity.kt
@@ -50,10 +50,6 @@
     @Inject
     lateinit var inputScreenOnboardingWideEvent: InputScreenOnboardingWideEvent
 
-    fun test() {
-
-    }
-
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setContentView(R.layout.activity_input_screen)

...ckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenActivity.kt

daxmobile · 2026-03-13T12:16:28Z

.github/workflows/ci.yml

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:16:29: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/ci.yml

Line 27 in 86984f7

run: |

daxmobile · 2026-03-13T12:16:28Z

.github/workflows/ci.yml

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:19:30: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/ci.yml

Line 27 in 86984f7

run: |

daxmobile · 2026-03-13T12:16:29Z

.github/workflows/ci.yml

📝 [actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:73: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/ci.yml

Line 27 in 86984f7

run: |

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.}

cursor · 2026-03-13T12:19:25Z

.github/workflows/ci.yml

        with:
          java-version-file: .github/.java-version
-          distribution: 'adopt'
+          distribution: 'adoptz'


Invalid JDK distribution name breaks CI unit tests

High Severity

The distribution value for actions/setup-java@v4 was changed from 'adopt' to 'adoptz', which is not a valid distribution identifier. This will cause the "Set up JDK version" step to fail in the unit_tests job, blocking all unit tests in CI. Every other job in this file and across other workflow files correctly uses 'adopt'.

_{Please tell me if this was useful or not with a 👍 or 👎.}

Task/Issue URL: https://app.asana.com/1/137249556945/project/1208671518894266/task/1213642299611483?focus=true ### Description Instead of skipping the workflow at the trigger level, the workflow now always runs but gates all jobs behind a check_changes job that inspects the diff. - If only `.md` or `.github/` files changed → all jobs are skipped (GitHub treats skipped as passing for branch protection) - If `ci.yml` itself changed → all jobs run normally, so regressions are caught before merging - If any code file changed → all jobs run normally ### Steps to test this PR QA optional: - Open a PR that only modifies an `.md` file → check_changes should pass, all other jobs should be skipped, PR should be mergeable - Open a PR that only modifies a `.github` workflow file (not `ci.yml`) → check_changes should pass, all other jobs should be skipped, PR should be mergeable - Open a PR that modifies `.github/workflows/ci.yml` → all jobs should run - Open a PR that modifies any source file → all jobs should run I tested all of these via #7962.  --- > [!NOTE] > **Medium Risk** > Modifies the CI workflow execution logic to conditionally skip most jobs based on diff contents, which could unintentionally reduce coverage if the change-detection logic is wrong. > > **Overview** > The CI workflow no longer uses trigger-level `paths-ignore`; instead it always starts and runs a new `check_changes` job that diffs the PR (or always allows `push`/`workflow_dispatch`) to decide whether checks should run. > > All existing jobs (`code_formatting`, `unit_tests`, `lint`, `android_tests`) now `need` `check_changes` and are gated by `if: needs.check_changes.outputs.should_run == 'true'`, so docs-only or non-`ci.yml` `.github/` changes skip the expensive checks while changes to `ci.yml` or any code still run the full suite. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 9ff5ad8. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>

cursor bot reviewed Mar 13, 2026

View reviewed changes

build-benchmarks/README.md Outdated Show resolved Hide resolved

LukasPaczos force-pushed the fix/lpaczos/pin-gradle-profiler-version-to-0.23.0-test branch from 9553e1a to 11b962b Compare March 13, 2026 12:03

cursor bot reviewed Mar 13, 2026

View reviewed changes

...ckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenActivity.kt Outdated Show resolved Hide resolved

LukasPaczos force-pushed the fix/lpaczos/always-run-ci-worflow branch from 281d5de to 14e5e16 Compare March 13, 2026 12:11

pin gradle-profiler version to 0.23.0 for the nightly build benchmarks

6bfda08

LukasPaczos force-pushed the fix/lpaczos/pin-gradle-profiler-version-to-0.23.0-test branch from 3fe7fcf to 6bfda08 Compare March 13, 2026 12:13

LukasPaczos added 3 commits March 13, 2026 13:14

test

cb30027

test

d6a28a1

test

86984f7

daxmobile reviewed Mar 13, 2026

View reviewed changes

LukasPaczos closed this Mar 13, 2026

LukasPaczos deleted the fix/lpaczos/pin-gradle-profiler-version-to-0.23.0-test branch March 13, 2026 12:17

cursor bot reviewed Mar 13, 2026

View reviewed changes

LukasPaczos mentioned this pull request Mar 13, 2026

always run ci.yml and skip jobs when needed #7964

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test of skipping ci.yml jobs#7962

test of skipping ci.yml jobs#7962
LukasPaczos wants to merge 4 commits intofix/lpaczos/always-run-ci-worflowfrom
fix/lpaczos/pin-gradle-profiler-version-to-0.23.0-test

LukasPaczos commented Mar 13, 2026 •

edited by cursor bot

Loading

Uh oh!

cursor bot left a comment •

edited

Loading

Uh oh!

Uh oh!

cursor bot left a comment •

edited

Loading

Uh oh!

Uh oh!

daxmobile Mar 13, 2026

Uh oh!

daxmobile Mar 13, 2026

Uh oh!

daxmobile Mar 13, 2026

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

LukasPaczos commented Mar 13, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

daxmobile Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

daxmobile Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

daxmobile Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Mar 13, 2026

Choose a reason for hiding this comment

Invalid JDK distribution name breaks CI unit tests

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LukasPaczos commented Mar 13, 2026 •

edited by cursor bot

Loading

cursor bot left a comment •

edited

Loading

cursor bot left a comment •

edited

Loading