PIR: Add kill switch for bundle json usage#8013
Merged
karlenDimla merged 2 commits intodevelopfrom Mar 19, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6 tasks
Base automatically changed from
feature/karl/pir/broker-json-bundle-pixel
to
develop
March 19, 2026 07:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/task/1213726950062648?focus=true
Description
Adds killswitch for broker bundle json usage
Steps to test this PR
Disable useBundledBrokerJsons and run https://app.asana.com/1/137249556945/task/1213721083788440?focus=true, verify that PIR-update: Bundled broker jsons disabled. Not loading bundled data. is shown for cases where buundle usage was expected.
Note
Medium Risk
Adds a new remote toggle that can disable the bundled broker-JSON fallback when network seeding fails, which could leave PIR without broker data in offline/BE-failure scenarios if misconfigured.
Overview
Adds a new PIR remote feature flag,
useBundledBrokerJsons(default enabled), to control whether bundled broker JSON assets may be used as a fallback.Updates
RealBrokerJsonUpdater.update()so that when the network update fails and no broker data is stored, it will skip loading bundled data and returnfalseif the toggle is disabled (with a new log message). Tests are updated to injectPirRemoteFeaturesand to cover both toggle-enabled and toggle-disabled fallback behavior.Written by Cursor Bugbot for commit 9ccf794. This will update automatically on new commits. Configure here.