Merged
Conversation
karlenDimla
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1210594645151737/task/1213720450436951?focus=true
Description
Adds a
PirProcessLifecycleObserversimilar to existingVpnProcessLifecycleObserverSteps to test this PR
Nothing to test
UI changes
No UI changes
Note
Low Risk
Low risk: adds a new lifecycle observer interface and dispatch hook for the
pirsecondary process, mirroring existing VPN behavior without changing core app flows or data handling.Overview
Adds support for a new
pirsecondary process lifecycle callback.DuckDuckGoApplicationnow recognizes thepirprocess name and dispatchesonPirProcessCreated()to a newPluginPoint<PirProcessLifecycleObserver>, alongside the existing VPN process handling. This PR also introduces thePirProcessLifecycleObserverinterface and an AnvilContributesPluginPoint(PirProcessLifecycleObserverPluginPoint) so features can register PIR process startup observers via DI.Written by Cursor Bugbot for commit 63fd802. This will update automatically on new commits. Configure here.