Skip to content

Add temporary pixel for PIR eligible#8024

Merged
karlenDimla merged 1 commit intodevelopfrom
feature/karl/pir/pixel-canrunpir
Mar 19, 2026
Merged

Add temporary pixel for PIR eligible#8024
karlenDimla merged 1 commit intodevelopfrom
feature/karl/pir/pixel-canrunpir

Conversation

@karlenDimla
Copy link
Contributor

@karlenDimla karlenDimla commented Mar 19, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/task/1213726950062653?focus=true

Description

See attached task description

Steps to test this PR

Feature 1

  • Install debug build
  • Verify m_dbp_user-eligible_d is not emitted
  • Obtain a susbcription
  • Verify that m_dbp_user-eligible_d is emitted
  • Reopen app and verify suucceeding pixels for m_dbp_user-eligible_d are dropped

Note

Low Risk
Low risk: adds a new analytics pixel and a single call site when canRunPir() becomes true, with minimal impact on PIR behavior beyond an extra enqueue.

Overview
Adds a new Android PIR daily analytics pixel, m_dbp_user-eligible_d, to report when a user is eligible to run PIR.

Wires the pixel through PirPixel/PirPixelSender and emits it from PirDataUpdateObserver when canRunPir() transitions to enabled; updates unit tests to inject and mock the new PirPixelSender dependency.

Written by Cursor Bugbot for commit 9635c94. This will update automatically on new commits. Configure here.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

Privacy Review task: https://app.asana.com/0/69071770703008/1213735155294654

Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: JSON5 pixel key includes redundant _d suffix
    • Changed pixel key from 'm_dbp_user-eligible_d' to 'm_dbp_user-eligible' to match the convention where the daily_count_short suffix appends '_d', preventing the double '_d_d' pattern.

Create PR

Or push these changes by commenting:

@cursor push d5f00974c4
Preview (d5f00974c4)
diff --git a/PixelDefinitions/pixels/personal_information_removal.json5 b/PixelDefinitions/pixels/personal_information_removal.json5
--- a/PixelDefinitions/pixels/personal_information_removal.json5
+++ b/PixelDefinitions/pixels/personal_information_removal.json5
@@ -1064,7 +1064,7 @@
             }
         ]
     },
-    "m_dbp_user-eligible_d": {
+    "m_dbp_user-eligible": {
         "description": "Android specific daily pixel fired when the user is eligible to run PIR (flag enabled, valid subscription, PIR entitlement, and repository available).",
         "owners": ["karlenDimla", "landomen"],
         "triggers": ["other"],

@karlenDimla karlenDimla force-pushed the feature/karl/pir/pixel-canrunpir branch from 2536f8d to 9635c94 Compare March 19, 2026 16:00
Copy link
Contributor

@landomen landomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karlenDimla karlenDimla merged commit 347a1c1 into develop Mar 19, 2026
21 checks passed
@karlenDimla karlenDimla deleted the feature/karl/pir/pixel-canrunpir branch March 19, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants