Add temporary pixel for PIR eligible#8024
Merged
karlenDimla merged 1 commit intodevelopfrom Mar 19, 2026
Merged
Conversation
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1213735155294654 |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: JSON5 pixel key includes redundant
_dsuffix- Changed pixel key from 'm_dbp_user-eligible_d' to 'm_dbp_user-eligible' to match the convention where the daily_count_short suffix appends '_d', preventing the double '_d_d' pattern.
Or push these changes by commenting:
@cursor push d5f00974c4
Preview (d5f00974c4)
diff --git a/PixelDefinitions/pixels/personal_information_removal.json5 b/PixelDefinitions/pixels/personal_information_removal.json5
--- a/PixelDefinitions/pixels/personal_information_removal.json5
+++ b/PixelDefinitions/pixels/personal_information_removal.json5
@@ -1064,7 +1064,7 @@
}
]
},
- "m_dbp_user-eligible_d": {
+ "m_dbp_user-eligible": {
"description": "Android specific daily pixel fired when the user is eligible to run PIR (flag enabled, valid subscription, PIR entitlement, and repository available).",
"owners": ["karlenDimla", "landomen"],
"triggers": ["other"],2536f8d to
9635c94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Task/Issue URL: https://app.asana.com/1/137249556945/task/1213726950062653?focus=true
Description
See attached task description
Steps to test this PR
Feature 1
Note
Low Risk
Low risk: adds a new analytics pixel and a single call site when
canRunPir()becomes true, with minimal impact on PIR behavior beyond an extra enqueue.Overview
Adds a new Android PIR daily analytics pixel,
m_dbp_user-eligible_d, to report when a user is eligible to run PIR.Wires the pixel through
PirPixel/PirPixelSenderand emits it fromPirDataUpdateObserverwhencanRunPir()transitions to enabled; updates unit tests to inject and mock the newPirPixelSenderdependency.Written by Cursor Bugbot for commit 9635c94. This will update automatically on new commits. Configure here.