Fix FileBasedFaviconPersister FileAlreadyExistsException

[joshliebe]

Task/Issue URL: https://app.asana.com/1/137249556945/project/1200204095367872/task/1213736584422142?focus=true

Description

• Catches FileAlreadyExistsException if copyTo throws

Steps to test this PR

• Verify that favicons work correctly

---

Note

Low Risk
Low risk: wraps a single file copy operation to avoid crashing when copy fails (e.g., existing destination/race), with no behavioral changes elsewhere.

Overview
Prevents crashes when persisting favicons by wrapping FileBasedFaviconPersister.copyToDirectory’s file.copyTo(...) call in runCatching, effectively swallowing FileAlreadyExistsException/IO failures during the copy.

^{Written by Cursor Bugbot for commit 2789592. This will update automatically on new commits. Configure here.}

[joshliebe]

• Fix FileBasedFaviconPersister FileAlreadyExistsException #8030 👈 (View in Graphite)
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Silent exception swallowing masks all copy failures
  • Replaced broad runCatching with explicit exception handling that logs copy failures and only catches Exception instead of all Throwable.

Or push these changes by commenting:

@cursor push a8b051c7d9

Preview (a8b051c7d9)

diff --git a/app/src/main/java/com/duckduckgo/app/browser/favicon/FaviconPersister.kt b/app/src/main/java/com/duckduckgo/app/browser/favicon/FaviconPersister.kt
--- a/app/src/main/java/com/duckduckgo/app/browser/favicon/FaviconPersister.kt
+++ b/app/src/main/java/com/duckduckgo/app/browser/favicon/FaviconPersister.kt
@@ -27,6 +27,7 @@
 import kotlinx.coroutines.sync.Mutex
 import kotlinx.coroutines.sync.withLock
 import kotlinx.coroutines.withContext
+import logcat.LogPriority.ERROR
 import logcat.LogPriority.INFO
 import logcat.logcat
 import java.io.File
@@ -96,7 +97,17 @@
     ) {
         withContext(dispatcherProvider.io()) {
             val persistedFile = fileForFavicon(directory, newSubfolder, newFilename)
-            runCatching { file.copyTo(persistedFile, overwrite = true) }
+            try {
+                file.copyTo(persistedFile, overwrite = true)
+            } catch (exception: FileAlreadyExistsException) {
+                logcat(INFO, exception) {
+                    "Favicon destination already exists and could not be replaced: ${persistedFile.absolutePath}"
+                }
+            } catch (exception: Exception) {
+                logcat(ERROR, exception) {
+                    "Failed to persist favicon to ${persistedFile.absolutePath}"
+                }
+            }
         }
     }