Add more tests for RealSqlCipherLoaderTest#8034
Merged
karlenDimla merged 1 commit intodevelopfrom Mar 20, 2026
Merged
Conversation
CDRussell
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1201462763415876/task/1213737428120588?focus=true
Description
Add back removed test for SqlCipher loader
Steps to test this PR
QA-optional
Note
Low Risk
Low risk: only unit test and Gradle test configuration changes, no production logic modifications. Main risk is potential test flakiness or slower test execution due to added Robolectric resources.
Overview
Adds a Robolectric-based test suite for
RealSqlCipherLoader.waitForLibraryLoad, covering success, load failure, timeout handling, cancellation propagation, single-initialization behavior, concurrent callers, and early-load triggers viaonCreate/onPirProcessCreated.Updates
sqlcipher-loader-impltest setup to support these cases by adding Robolectric/AndroidX test dependencies, enablingincludeAndroidResources, and introducing aShadowLibraryLoaderto simulate native library load callbacks without loading real binaries.Written by Cursor Bugbot for commit 143c446. This will update automatically on new commits. Configure here.