add animated toggle on the onboarding input selection screen#8254
add animated toggle on the onboarding input selection screen#8254LukasPaczos merged 2 commits intodevelopfrom
Conversation
b1b4f16 to
de2adb3
Compare
61ebe61 to
e1e62c1
Compare
e1e62c1 to
40fe5f6
Compare
40fe5f6 to
3685596
Compare
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3685596. Configure here.
Clean up animator listeners during view teardown to prevent IllegalStateException when callbacks access viewLifecycleOwner after the view is destroyed. Also clear stale listeners on the back view during crossfade to prevent orphaned repeat jobs on rapid toggling.
|
@LukasPaczos It definitely works! 🚀 But I'm noticing that it takes quite a while for the animation to play when landing on the screen, and I wonder if it's almost too long so people will actually never see it. I'm guessing everything is according to spec? Regardless, I think we would benefit with playing it a little quicker |
mikescamell
left a comment
There was a problem hiding this comment.
Works as expected! ![]()
But I think it's worth clarifying with design if we really want to wait that long for the animation to play, but it might be my bias as I know the onboarding steps 😅 #8254 (comment)
|
The initial 2 seconds delay is by design. Feels a little too long for me too but it might be our bias - I think we can adjust as we go and as people start playing around with it in test builds. |

Task/Issue URL: https://app.asana.com/1/137249556945/project/1208671518894266/task/1213981966750223?focus=true
Description
Replaces static
ImageViewdrawables with Lottie animations for the AI Chat toggle on the onboarding input selection screen. Animations loop with a 2-second delay between repeats. When the user switches between options, the Lottie crossfade preserves the current animation progress for a seamless transition.Steps to test this PR
Apply patch
UI changes
onboarding-input-toggle-animation-v2.mp4
Note
Medium Risk
UI-only change but adds new Lottie animation assets plus coroutine-driven looping/crossfade logic that could regress onboarding rendering or leak/cancel incorrectly across lifecycle events.
Overview
Adds animated Lottie-based visuals for the onboarding input selection toggle ("Search only" vs "Search + AI Chat"), replacing the previous static assets and selecting light/dark variants.
Updates the onboarding screen logic to manage toggle state transitions via
InputToggleTransition, including seamless crossfades that preserve Lottie progress and a delayed repeat loop; also tightens lifecycle cleanup by cancelling jobs, listeners, and animations on teardown.Moves/introduces new resources: vector drawables for the non-AI state and four Lottie JSONs for the AI state, while removing the old
duckchat-implsearchbox vector assets.Reviewed by Cursor Bugbot for commit 3f02c05. Bugbot is set up for automated code reviews on this repo. Configure here.