Skip to content

Remove intermediate focus state (Native Input)#8326

Merged
joshliebe merged 1 commit into
developfrom
feature/josh/remove-intermediate-focus
Apr 21, 2026
Merged

Remove intermediate focus state (Native Input)#8326
joshliebe merged 1 commit into
developfrom
feature/josh/remove-intermediate-focus

Conversation

@joshliebe
Copy link
Copy Markdown
Contributor

@joshliebe joshliebe commented Apr 20, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1213890328647785?focus=true

Description

  • Removes the intermediate unfocussed state of the native input

Steps to test this PR

With native input enabled

  • Focus the omnibar
  • Verify that the native input is shown
  • Go back or hide the keyboard
  • Verify that the unfocussed omnibar is shown

Repeat for top, bottom and split configurations


Note

Medium Risk
Behavior and animation changes in keyboard hide/show flows can cause regressions in native-input layout, focus, and visual transitions across top/bottom omnibar modes.

Overview
Removes the “intermediate” native-input UI state by deleting card width/margin animations and related layout tweaking.

NativeInputManager now skips bottom-card expansion and end-margin adjustments on keyboard visibility changes; on keyboard hide (non-DuckAI) it shows a transparent omnibar and then schedules hideNativeInput() instead of keeping a rounded/inset widget card visible. Related API surface is simplified by removing animateCardWidth, applyRoundedCardShape, and getButtonsWidth, and cancelAnimation() no longer manages a separate card-width animator.

Reviewed by Cursor Bugbot for commit 34c2172. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 34c2172. Configure here.

Copy link
Copy Markdown
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works as expected, much better!

@joshliebe joshliebe merged commit c593489 into develop Apr 21, 2026
25 checks passed
@joshliebe joshliebe deleted the feature/josh/remove-intermediate-focus branch April 21, 2026 15:32
malmstein pushed a commit that referenced this pull request Apr 22, 2026
Task/Issue URL:
https://app.asana.com/1/137249556945/project/488551667048375/task/1213890328647785?focus=true

### Description

- Removes the intermediate unfocussed state of the native input

### Steps to test this PR

_With native input enabled_
- [ ] Focus the omnibar
- [ ] Verify that the native input is shown
- [ ] Go back or hide the keyboard
- [ ] Verify that the unfocussed omnibar is shown

Repeat for top, bottom and split configurations

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Behavior and animation changes in keyboard hide/show flows can cause
regressions in native-input layout, focus, and visual transitions across
top/bottom omnibar modes.
> 
> **Overview**
> Removes the “intermediate” native-input UI state by deleting card
width/margin animations and related layout tweaking.
> 
> `NativeInputManager` now skips bottom-card expansion and end-margin
adjustments on keyboard visibility changes; on keyboard hide
(non-DuckAI) it shows a transparent omnibar and then schedules
`hideNativeInput()` instead of keeping a rounded/inset widget card
visible. Related API surface is simplified by removing
`animateCardWidth`, `applyRoundedCardShape`, and `getButtonsWidth`, and
`cancelAnimation()` no longer manages a separate card-width animator.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
34c2172. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants