Remove intermediate focus state (Native Input)#8326
Merged
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 34c2172. Configure here.
malmstein
approved these changes
Apr 21, 2026
Contributor
malmstein
left a comment
There was a problem hiding this comment.
tested and works as expected, much better!
malmstein
pushed a commit
that referenced
this pull request
Apr 22, 2026
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1213890328647785?focus=true ### Description - Removes the intermediate unfocussed state of the native input ### Steps to test this PR _With native input enabled_ - [ ] Focus the omnibar - [ ] Verify that the native input is shown - [ ] Go back or hide the keyboard - [ ] Verify that the unfocussed omnibar is shown Repeat for top, bottom and split configurations <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Behavior and animation changes in keyboard hide/show flows can cause regressions in native-input layout, focus, and visual transitions across top/bottom omnibar modes. > > **Overview** > Removes the “intermediate” native-input UI state by deleting card width/margin animations and related layout tweaking. > > `NativeInputManager` now skips bottom-card expansion and end-margin adjustments on keyboard visibility changes; on keyboard hide (non-DuckAI) it shows a transparent omnibar and then schedules `hideNativeInput()` instead of keeping a rounded/inset widget card visible. Related API surface is simplified by removing `animateCardWidth`, `applyRoundedCardShape`, and `getButtonsWidth`, and `cancelAnimation()` no longer manages a separate card-width animator. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 34c2172. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1213890328647785?focus=true
Description
Steps to test this PR
With native input enabled
Repeat for top, bottom and split configurations
Note
Medium Risk
Behavior and animation changes in keyboard hide/show flows can cause regressions in native-input layout, focus, and visual transitions across top/bottom omnibar modes.
Overview
Removes the “intermediate” native-input UI state by deleting card width/margin animations and related layout tweaking.
NativeInputManagernow skips bottom-card expansion and end-margin adjustments on keyboard visibility changes; on keyboard hide (non-DuckAI) it shows a transparent omnibar and then scheduleshideNativeInput()instead of keeping a rounded/inset widget card visible. Related API surface is simplified by removinganimateCardWidth,applyRoundedCardShape, andgetButtonsWidth, andcancelAnimation()no longer manages a separate card-width animator.Reviewed by Cursor Bugbot for commit 34c2172. Bugbot is set up for automated code reviews on this repo. Configure here.