Skip to content

Show correct menu icon on app startup#8337

Merged
joshliebe merged 1 commit into
developfrom
feature/josh/menu-icon-startup
Apr 24, 2026
Merged

Show correct menu icon on app startup#8337
joshliebe merged 1 commit into
developfrom
feature/josh/menu-icon-startup

Conversation

@joshliebe
Copy link
Copy Markdown
Contributor

@joshliebe joshliebe commented Apr 22, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1214187547786023?focus=true

Description

  • The menu icon was recently updated but the mock omnibar/layout XML still use the old icon, which means it shows briefly on startup.

Solution

  • When we bindMockupToolbars then the icon should be set based on the menu feature flag.

  • The initial BrowserMenuDisplayState should be the actual state based on the feature flag instead of false.

Steps to test this PR

  • Kill the app and reopen
  • Verify that the correct menu icon is shown on startup

UI changes

Before After
Screenshot_20260422_215028 Screenshot_20260422_214713

Note

Low Risk
Low risk UI-state change: adds a synchronous check for the bottom-sheet menu flag to avoid incorrect initial state before flows emit, with unit tests covering the new logic.

Overview
Ensures the browser menu icon is correct immediately on startup by introducing BrowserMenuDisplayRepository.isBottomSheetMenuEnabled() and using it to set initial useBottomSheetMenu/menu icon state before reactive flows emit.

BrowserActivity now picks the mock toolbar menu icon (hamburger vs vertical) based on this synchronous check, and BrowserTabViewModel initializes browserMenuState/BrowserViewState with the same derived value. Adds unit tests for the new enablement computation across rollout/experimental flags and user preference.

Reviewed by Cursor Bugbot for commit 6152118. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected. LGTM

@joshliebe joshliebe merged commit dfc371b into develop Apr 24, 2026
25 of 32 checks passed
@joshliebe joshliebe deleted the feature/josh/menu-icon-startup branch April 24, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants