Show correct menu icon on app startup#8337
Merged
Merged
Conversation
malmstein
approved these changes
Apr 24, 2026
Contributor
malmstein
left a comment
There was a problem hiding this comment.
works as expected. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1214187547786023?focus=true
Description
Solution
When we
bindMockupToolbarsthen the icon should be set based on the menu feature flag.The initial
BrowserMenuDisplayStateshould be the actual state based on the feature flag instead of false.Steps to test this PR
UI changes
Note
Low Risk
Low risk UI-state change: adds a synchronous check for the bottom-sheet menu flag to avoid incorrect initial state before flows emit, with unit tests covering the new logic.
Overview
Ensures the browser menu icon is correct immediately on startup by introducing
BrowserMenuDisplayRepository.isBottomSheetMenuEnabled()and using it to set initialuseBottomSheetMenu/menu icon state before reactive flows emit.BrowserActivitynow picks the mock toolbar menu icon (hamburger vs vertical) based on this synchronous check, andBrowserTabViewModelinitializesbrowserMenuState/BrowserViewStatewith the same derived value. Adds unit tests for the new enablement computation across rollout/experimental flags and user preference.Reviewed by Cursor Bugbot for commit 6152118. Bugbot is set up for automated code reviews on this repo. Configure here.