Skip to content

Remove favorites from Duck.ai tab (Native Input)#8343

Merged
joshliebe merged 1 commit into
developfrom
feature/josh/remove-favorites-duck-ai
Apr 24, 2026
Merged

Remove favorites from Duck.ai tab (Native Input)#8343
joshliebe merged 1 commit into
developfrom
feature/josh/remove-favorites-duck-ai

Conversation

@joshliebe
Copy link
Copy Markdown
Contributor

@joshliebe joshliebe commented Apr 23, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/1200204095367872/task/1213821485629415?focus=true

Description

  • Hides favorites when toggling to search on a Duck.ai tab

Steps to test this PR

With native input enabled

  • Add a favorite
  • Go to Duck.ai
  • Toggle to search
  • Verify that the favorite does not show
  • Type something
  • Clear it
  • Verify that the favorite does not show

Note

Low Risk
Low risk: small, localized callback changes in NativeInputManager affecting autocomplete clearing behavior, with minimal impact outside Duck.ai mode.

Overview
Adjusts native input callback handling so that in Duck.ai mode clearing the search field triggers onClearAutocomplete (instead of propagating an empty onSearchTextChanged).

Also updates search-tab selection handling to clear autocomplete and short-circuit further selection behavior when the text is blank in Duck.ai mode.

Reviewed by Cursor Bugbot for commit 4a14205. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joshliebe joshliebe assigned malmstein and unassigned malmstein Apr 23, 2026
Copy link
Copy Markdown
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, nice one!

@joshliebe joshliebe merged commit 68f6292 into develop Apr 24, 2026
28 checks passed
@joshliebe joshliebe deleted the feature/josh/remove-favorites-duck-ai branch April 24, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants