Skip to content

Conversation

@cmonfortep
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/0/1177606971489473/f
Tech Design URL:
CC:

Description:
Adding the latest subset of translations related to the fireproof concept and other features:

  • Download confirmations
  • Change app icon
  • Fireproof websites
  • Privacy protection whitelist

Steps to test this PR:
1.
1.


Internal references:

Software Engineering Expectations
Technical Design Template

<string name="daxNonSerpCtaText">A medida que navegues y te desplaces, bloquearé rastreadores molestos. &lt;br/&gt;&lt;br/&gt;Adelante, ¡sigue navegando!</string>
<string name="daxMainNetworkOwnedCtaText">¡Cuidado! %s pertenece %s.&lt;br/&gt;&lt;br/&gt;Los rastreadores de %s acechan en %s de los principales sitios web &#128561; ¡pero no te preocupes! &lt;br/&gt;&lt;br/&gt;Bloquearé a %s para que no vean tu actividad en esos sitios.</string>
<string name="daxMainNetworkCtaText">¡Cuidado! %s es una importante red de rastreo.&lt;br/&gt;&lt;br/&gt; Sus rastreadores acechan en aproximadamente %s de los sitios principales &#128561; ¡pero no te preocupes! &lt;br/&gt;&lt;br/&gt;Bloquearé a %s para que no vea tu actividad en esos sitios.</string>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcosholgado please take a look to this translations in case you have any proposal.

Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes in the spanish translation but apart from that all looking good.

<string name="changeIconCtaLabel">Cambiar icono de la aplicación</string>
<string name="changeIconCtaAccept">Usar</string>
<string name="changeIconCtaCancel">Cancelar</string>
<string name="changeIconDialogTitle">¿Usar nuevo ícono?</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icono doesn't need the accent

<string name="changeIconCtaAccept">Usar</string>
<string name="changeIconCtaCancel">Cancelar</string>
<string name="changeIconDialogTitle">¿Usar nuevo ícono?</string>
<string name="changeIconDialogMessage">La aplicación puede cerrarse para actualizar los cambios. Vuelve después de que hayas admirado tu nuevo y atractivo icono.</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 that is so good!

<string name="whitelistExplanation">Estos sitios web incluidos en la lista blanca no se actualizarán por Protección de Privacidad</string>
<string name="whitelistNoEntries">Aún no hay sitios web en la lista blanca</string>
<string name="whitelistDomainHint">www.ejemplo.com</string>
<string name="whitelistFormatError">No se ha podido guardar, ingresa un dominio como <b>example.com</b>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change example.com to ejemplo.com like in whitelistDomainHint?

<string name="fireproofWebsitesActivityTitle">Sitios web a prueba de fuego</string>
<string name="settingsFireproofWebsites">Sitios web a prueba de fuego</string>
<string name="fireproofWebsiteMenuTitle">Sitio web a prueba de fuego</string>
<string name="fireproofWebsiteSnackbarConfirmation"&lt;b&gt;%s&lt;/b&gt; ahora es a prueba de fuego! Visita Ajustes para obtener más información.</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would say ... es ahora a prueba de fuego! rather than using ahora first 🤷

<string name="fireproofWebsiteSnackbarConfirmation"&lt;b&gt;%s&lt;/b&gt; ahora es a prueba de fuego! Visita Ajustes para obtener más información.</string>
<string name="fireproofWebsiteSnackbarAction">Deshacer</string>
<string name="fireproofWebsiteDeleteConfirmMessage">¿Está seguro de que desea eliminar &lt;b&gt;%s&lt;/b&gt;?</string>
<string name="fireproofWebsiteEmptyListHint">No hay sitios web a prueba de fuego todavía</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todavía no hay sitios web a prueba de fuego? Using todavía at the end seems a direct translation from yet.

@cmonfortep cmonfortep changed the title Add latests translations into project Add latest translations into project May 28, 2020
@cmonfortep cmonfortep requested a review from marcosholgado May 28, 2020 14:40
@cmonfortep
Copy link
Contributor Author

@marcosholgado you can recheck. Suggestions added to Spanish translations.

Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

# Conflicts:
#	app/src/main/res/values/string-untranslated.xml
@cmonfortep cmonfortep merged commit 478d13c into develop Jun 2, 2020
@cmonfortep cmonfortep deleted the feature/cristian/fireproof/translations branch June 2, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants