-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add latest translations into project #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| <string name="daxNonSerpCtaText">A medida que navegues y te desplaces, bloquearé rastreadores molestos. <br/><br/>Adelante, ¡sigue navegando!</string> | ||
| <string name="daxMainNetworkOwnedCtaText">¡Cuidado! %s pertenece %s.<br/><br/>Los rastreadores de %s acechan en %s de los principales sitios web 😱 ¡pero no te preocupes! <br/><br/>Bloquearé a %s para que no vean tu actividad en esos sitios.</string> | ||
| <string name="daxMainNetworkCtaText">¡Cuidado! %s es una importante red de rastreo.<br/><br/> Sus rastreadores acechan en aproximadamente %s de los sitios principales 😱 ¡pero no te preocupes! <br/><br/>Bloquearé a %s para que no vea tu actividad en esos sitios.</string> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcosholgado please take a look to this translations in case you have any proposal.
marcosholgado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes in the spanish translation but apart from that all looking good.
| <string name="changeIconCtaLabel">Cambiar icono de la aplicación</string> | ||
| <string name="changeIconCtaAccept">Usar</string> | ||
| <string name="changeIconCtaCancel">Cancelar</string> | ||
| <string name="changeIconDialogTitle">¿Usar nuevo ícono?</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
icono doesn't need the accent
| <string name="changeIconCtaAccept">Usar</string> | ||
| <string name="changeIconCtaCancel">Cancelar</string> | ||
| <string name="changeIconDialogTitle">¿Usar nuevo ícono?</string> | ||
| <string name="changeIconDialogMessage">La aplicación puede cerrarse para actualizar los cambios. Vuelve después de que hayas admirado tu nuevo y atractivo icono.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆 that is so good!
| <string name="whitelistExplanation">Estos sitios web incluidos en la lista blanca no se actualizarán por Protección de Privacidad</string> | ||
| <string name="whitelistNoEntries">Aún no hay sitios web en la lista blanca</string> | ||
| <string name="whitelistDomainHint">www.ejemplo.com</string> | ||
| <string name="whitelistFormatError">No se ha podido guardar, ingresa un dominio como <b>example.com</b> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change example.com to ejemplo.com like in whitelistDomainHint?
| <string name="fireproofWebsitesActivityTitle">Sitios web a prueba de fuego</string> | ||
| <string name="settingsFireproofWebsites">Sitios web a prueba de fuego</string> | ||
| <string name="fireproofWebsiteMenuTitle">Sitio web a prueba de fuego</string> | ||
| <string name="fireproofWebsiteSnackbarConfirmation">¡<b>%s</b> ahora es a prueba de fuego! Visita Ajustes para obtener más información.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would say ... es ahora a prueba de fuego! rather than using ahora first 🤷
| <string name="fireproofWebsiteSnackbarConfirmation">¡<b>%s</b> ahora es a prueba de fuego! Visita Ajustes para obtener más información.</string> | ||
| <string name="fireproofWebsiteSnackbarAction">Deshacer</string> | ||
| <string name="fireproofWebsiteDeleteConfirmMessage">¿Está seguro de que desea eliminar <b>%s</b>?</string> | ||
| <string name="fireproofWebsiteEmptyListHint">No hay sitios web a prueba de fuego todavía</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Todavía no hay sitios web a prueba de fuego? Using todavía at the end seems a direct translation from yet.
|
@marcosholgado you can recheck. Suggestions added to Spanish translations. |
marcosholgado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
# Conflicts: # app/src/main/res/values/string-untranslated.xml
Task/Issue URL: https://app.asana.com/0/0/1177606971489473/f
Tech Design URL:
CC:
Description:
Adding the latest subset of translations related to the fireproof concept and other features:
Steps to test this PR:
1.
1.
Internal references:
Software Engineering Expectations
Technical Design Template