Skip to content

Update promo modal origins#8527

Open
nalcalag wants to merge 1 commit into
developfrom
feature/noelia/update_promo_modal_origins
Open

Update promo modal origins#8527
nalcalag wants to merge 1 commit into
developfrom
feature/noelia/update_promo_modal_origins

Conversation

@nalcalag
Copy link
Copy Markdown
Contributor

@nalcalag nalcalag commented May 12, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/task/1214600823883574?focus=true

Description

Update promo modal origins to match new specs

Steps to test this PR (Optional)

  • Check origins are updated
  • Check CI checks are ✅

No UI changes


Note

Low Risk
Low risk: changes are limited to updating origin query parameter values for subscription promo modals and aligning unit tests; no logic flow or data handling is modified.

Overview
Updates the origin strings passed by CtaViewModel.getPromoCtaOnForeground for the two subscription promo modal cases to match new funnel naming specs.

Adjusts related unit tests (BrowserTabViewModelTest, CtaViewModelTest) to assert the new origin query parameter values when launching subscriptions and when recording CTA interactions.

Reviewed by Cursor Bugbot for commit 6f6d0ce. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag marked this pull request as ready for review May 12, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants