Update promo modal origins#8527
Open
nalcalag wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/task/1214600823883574?focus=true
Description
Update promo modal origins to match new specs
Steps to test this PR (Optional)
No UI changes
Note
Low Risk
Low risk: changes are limited to updating
originquery parameter values for subscription promo modals and aligning unit tests; no logic flow or data handling is modified.Overview
Updates the
originstrings passed byCtaViewModel.getPromoCtaOnForegroundfor the two subscription promo modal cases to match new funnel naming specs.Adjusts related unit tests (
BrowserTabViewModelTest,CtaViewModelTest) to assert the neworiginquery parameter values when launching subscriptions and when recording CTA interactions.Reviewed by Cursor Bugbot for commit 6f6d0ce. Bugbot is set up for automated code reviews on this repo. Configure here.