Onboarding Brand Design Update: Add in-context Trackers Blocked dialog v2#8565
Merged
mikescamell merged 5 commits intoMay 14, 2026
Conversation
- base class onTypingAnimationSettled defaults to no-op so only DaxTrackersBlocked triggers the privacy-shield highlight, matching legacy single-CTA gating (C1) - TrackersBlocked stub docstring reflects the no-op default (C2) - hideOnboardingCta cancels the typing animation defensively (I3) - base-class tests cover the empty-title branch and assert titleView.alpha on mid-animation tap-to-skip (I2) - renamed rapidDoubleTap test to respectsAlreadySettledFlag (M1) - Skill 2 preconditions table uses actual sentinel hint names (I1)
…xtual dialog Populate the Stage-1 stub with the dynamic trackers description helper and the onTypingAnimationSettled override, replace sentinels across CtaViewModel and BrowserTabViewModel, and add the per-dialog unit test.
8 WebP variants (4 densities × light/dark) at 90% quality. Used by the TrackersBlocked CTA and shared by MainNetwork and NoTrackers when their banners land in subsequent stack branches.
mikescamell
force-pushed
the
feature/mike/onboarding-brand-design-updates/contextual-trackers-blocked
branch
from
c93d5b5 to
a1c4212
Compare
aibrahim-
approved these changes
May 14, 2026
mikescamell
deleted the
feature/mike/onboarding-brand-design-updates/contextual-trackers-blocked
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1214598065379691?focus=true
This was accidentally removed from develop.
See #8479 for description.
Note
Medium Risk
Changes onboarding CTA selection/rendering for the trackers-blocked flow and its interaction timing, which could affect when dialogs show and how the privacy shield highlight is triggered. Risk is mitigated by added unit tests around toggle behavior and pixel/dismissal side effects.
Overview
Routes the trackers blocked onboarding CTA to a new
DaxTrackersBlockedBrandDesignUpdateContextualCtawhen the brand-design update is enabled, while keeping the legacyOnboardingDaxDialogCta.DaxTrackersBlockedCtapath as fallback.Fills in the previously-stubbed brand-design CTA to render the trackers-blocked description, apply a dedicated background, wire the primary button click, and trigger the post-typing callback used to mirror the legacy privacy-shield highlight behavior.
Adds a focused test suite covering toggle-based CTA selection plus pixel firing and dismissal persistence for the new CTA.
Reviewed by Cursor Bugbot for commit a1c4212. Bugbot is set up for automated code reviews on this repo. Configure here.