Skip to content

Failing pixels report#8596

Merged
anikiki merged 1 commit into
developfrom
fix/ana/failing_pixels_report_widgets
May 18, 2026
Merged

Failing pixels report#8596
anikiki merged 1 commit into
developfrom
fix/ana/failing_pixels_report_widgets

Conversation

@anikiki
Copy link
Copy Markdown
Contributor

@anikiki anikiki commented May 18, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/task/1214864368587046?focus=true

Description

Removed unnecessary atb param from the below pixels:

m_duckai_only_widget_added
m_search_only_widget_added
m_search_only_widget_deleted

Steps to test this PR

  • No QA, code review only.

NO UI changes


Note

Cursor Bugbot is generating a summary for commit e7a2007. Configure here.

Copy link
Copy Markdown
Contributor Author

anikiki commented May 18, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@anikiki anikiki changed the title Remove unnecessary pixel parameters for widget actions in PixelParamRemovalInterceptor. Failing pixels report May 18, 2026
@anikiki anikiki marked this pull request as ready for review May 18, 2026 10:55
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e7a2007. Configure here.

AppPixelName.ERROR_CODE_PIXEL.pixelName to PixelParameter.removeAtb(),
AppPixelName.DUCKAI_ONLY_WIDGET_ADDED.pixelName to PixelParameter.removeAtb(),
AppPixelName.SEARCH_ONLY_WIDGET_ADDED.pixelName to PixelParameter.removeAtb(),
AppPixelName.SEARCH_ONLY_WIDGET_DELETED.pixelName to PixelParameter.removeAtb(),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing DUCKAI_ONLY_WIDGET_DELETED from ATB removal interceptor

Medium Severity

DUCKAI_ONLY_WIDGET_DELETED is defined in AppPixelName but missing from the ATB removal interceptor, breaking the consistent pattern. Every other widget pixel pair (SEARCH_AND_FAVORITES_WIDGET_ADDED/_DELETED, SEARCH_WIDGET_ADDED/_DELETED, SEARCH_ONLY_WIDGET_ADDED/_DELETED) includes both the _ADDED and _DELETED variants in the interceptor. DUCKAI_ONLY_WIDGET_ADDED was added here but DUCKAI_ONLY_WIDGET_DELETED was not, so when it fires it will still include the ATB param.


Please tell me if this was useful or not with a 👍 or 👎.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e7a2007. Configure here.

@catalinradoiu catalinradoiu self-assigned this May 18, 2026
@anikiki anikiki merged commit d4750d8 into develop May 18, 2026
30 of 32 checks passed
@anikiki anikiki deleted the fix/ana/failing_pixels_report_widgets branch May 18, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants